Refuel for non-AllVehicle objects #5151

tbeswick96 · 2017-05-10T21:43:37Z

When merged this pull request will:

Add helper.p3d from fastroping
Create helper object for non-AllVehicles objects, allowing refuel to be configured for more stuff (sling-loadable barrels for example)
Un-magic refuel progress timer value

This adds a workaround which makes it possible to have a fuel hose (an arma rope) coming from a non-physx object (limitation of ropeCreate) by using an invisible helper object which the rope is connected to instead - such that it looks like it connects to the actual object.

This has been used for sling-loadable fuel barrels for a number of weeks with no issues. These can be found here: https://github.com/uksf/modpack/blob/master/addons/vehicles/CfgVehicles.hpp#L102

…s timer.

…en rope attached.

PabstMirror · 2017-05-10T21:54:10Z

I think this should let us fix #3310

tbeswick96 · 2017-05-10T21:58:07Z

Not sure if damage from collisions would be an issue. Didn't BIS disable collisions of attachTo'd objects recently?

tbeswick96 · 2017-05-10T22:01:18Z

commy2 · 2017-05-11T00:23:13Z

addons/refuel/CfgVehicles.hpp

+    class GVAR(helper): Helicopter_Base_F {
+        author = "Beswick.T";
+        scope = 1;
+        model = QPATHTOF(data\helper.p3d);


Is this an actual model or just an empty dummy? One can use model = "-"; instead for no model.

It's an empty dummy. Tried and it doesn't work with "-", just gives an error.

What about:

model = "\A3\Weapons_f\empty";

?

Will give that a shot 1 min

That seems to work juuuust fine

tbeswick96 · 2017-05-11T00:34:30Z

Have done a little more playing around, and although it fixes the issue for things like the Huron fuel container, it doesn't fix it for buildings like the fuel bladder. It seems when the helper is attached to the fuel bladder, it loses simulation. Detach it and it's fine. Unsure how to get around that...is there a way to make an object static in a position without disabling simulation?

Edit: I've found a solution where the helper object simply is not attachTo'd the target object. The rope simulation works fine now, and using hideObjectGlobal ensures collisions don't occur. I am having some issues with the position of the rope now though. It's not taking into account object rotation.

tbeswick96 · 2017-05-11T01:12:12Z

Think I've solved it!

If the simulation type is thingX, which handles attachTo just fine with rope simulation, it will use that, otherwise it will set the helper position, direction, and vectorUp to the same as the target's, resulting in proper positioning. This should be fine, as it's not everyday a house or fuel pump gets up and walks away.

Hope this satisfies :)

…uction effects of helper object.

bux · 2017-05-11T06:21:31Z

Could you explain a little more in your OP what this does and what's being improved?
I'd like to know more.

And it would be helpful when writing the change logs.

kymckay · 2017-05-11T08:24:39Z

addons/refuel/functions/fnc_takeNozzle.sqf

+            private _ropeTarget = _target;
+            if (!(_target isKindOf "AllVehicles")) then {
+                private _helper = QGVAR(helper) createVehicle [0,0,0];
+                hideObjectGlobal _helper;


Keep in mind this has to run on the server, there is an event in common that can handle the locality:

[QEGVAR(common,hideObjectGlobal), [_helper, true]] call CBA_fnc_serverEvent;

kymckay · 2017-05-11T09:00:20Z

To give @bux some context: This adds a workaround which makes it possible to have a fuel hose (an arma rope) coming from a non-physx object (limitation of ropeCreate) by using an invisible helper object which the rope is connected to instead - such that it looks like it connects to the actual object.

… into tbeswick96-refuelimprovements

PabstMirror · 2017-05-11T20:52:19Z

Pushed some config changes to disable actions on the helper
I tested this in 2 player mp and it seemed to be working fine

IIRC it's a little dangerous to setVariable on map objects because they are technically "streaming".
And might be deleted and come back with no variables.
But I don't think it would cause any serious issues, and the functionality gains are worth it.

jonpas · 2017-05-11T20:54:30Z

addons/repair/CfgEventHandlers.hpp

@@ -37,7 +37,7 @@ class Extended_InitPost_EventHandlers {
    class Helicopter {
        class ADDON {
            init = QUOTE(_this call DFUNC(addRepairActions));
-            exclude[] = {QEGVAR(fastroping,helper), "ACE_friesBase"};
+            exclude[] = {QEGVAR(fastroping,helper), "ACE_friesBase", QEGVAR(refuel,helper)};


I believe this fastroping helper does not need to be here anymore.

tbeswick96 · 2017-05-11T20:58:07Z

@PabstMirror just so I can understand better, when you say streaming is that to do with view distance? So the vars are there when in view but if you go far away and back the vars might not be there?

jonpas · 2017-05-11T21:00:27Z

@tbeswick96 Correct.

I think the gains are well worth it, maybe we could have a map of building positions to data that would allow that to be persistent. But I'd say that's for another PR anyways.

PabstMirror · 2017-05-11T21:01:06Z

http://killzonekid.com/arma-scripting-tutorials-variables-part-3/

Houses for example like other map objects (and I mean map objects that have been added during map creation, not mission objects) are streamed. Think about it, the maps in ArmA are huge so even if you can load the whole map you will be using too much computer power. This is unnecessary, so map objects are streamed to you as you go. This means that if you attach a variable to an object on your map and try to make it global, on other computers the same object might not exist yet. And when the object appears later on other computers, it might not have variable you attached to it, so remember this.

tbeswick96 · 2017-05-11T21:02:42Z

Can just change the setVar to be on the nozzle instead if that is preferred? Not sure about the other setVars on the target

tbeswick96 added 2 commits May 10, 2017 22:36

Enabled refuel for non-AllVehicles objects. Un-magic'd refuel progres…

cf8421f

…s timer.

Changed helper attach position to centre of object. Offset applied wh…

1104a59

…en rope attached.

jonpas added the kind/enhancement Release Notes: **IMPROVED:** label May 10, 2017

jonpas added this to the 3.10.0 milestone May 10, 2017

commy2 reviewed May 11, 2017

View reviewed changes

tbeswick96 added 2 commits May 11, 2017 02:13

Made fully compatible with non-thingX simulation types. Removed destr…

89bcca3

…uction effects of helper object.

Using arma model. Removed ACE_Actions from helper object.

d8a7ef4

kymckay reviewed May 11, 2017

View reviewed changes

tbeswick96 and others added 3 commits May 11, 2017 15:07

Correct use of hideObjectGlobal

08440d3

Merge branch 'refuelimprovements' of https://github.com/tbeswick96/ACE3…

014c849

… into tbeswick96-refuelimprovements

Remove actions, cargo, repair on helper

d0298d9

PabstMirror changed the base branch from master to 170UBC May 11, 2017 20:47

PabstMirror changed the base branch from 170UBC to master May 11, 2017 20:48

jonpas reviewed May 11, 2017

View reviewed changes

Switched helper to be setVar'd on the nozzle object

e18fe02

PabstMirror approved these changes May 29, 2017

View reviewed changes

PabstMirror merged commit 3b7a304 into acemod:master May 29, 2017

PabstMirror mentioned this pull request May 29, 2017

Huron fuel Container has no visible hose #3310

Closed

tbeswick96 deleted the refuelimprovements branch May 29, 2017 19:22

kymckay mentioned this pull request Jun 12, 2017

Cleanup heli pod actions #5271

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refuel for non-AllVehicle objects #5151

Refuel for non-AllVehicle objects #5151

tbeswick96 commented May 10, 2017 •

edited

Loading

PabstMirror commented May 10, 2017

tbeswick96 commented May 10, 2017

tbeswick96 commented May 10, 2017

commy2 May 11, 2017

tbeswick96 May 11, 2017

commy2 May 11, 2017

tbeswick96 May 11, 2017

tbeswick96 May 11, 2017

tbeswick96 commented May 11, 2017 •

edited

Loading

tbeswick96 commented May 11, 2017 •

edited

Loading

bux commented May 11, 2017

kymckay May 11, 2017

kymckay commented May 11, 2017

PabstMirror commented May 11, 2017

jonpas May 11, 2017

tbeswick96 commented May 11, 2017

jonpas commented May 11, 2017 •

edited

Loading

PabstMirror commented May 11, 2017

tbeswick96 commented May 11, 2017 •

edited

Loading

Refuel for non-AllVehicle objects #5151

Refuel for non-AllVehicle objects #5151

Conversation

tbeswick96 commented May 10, 2017 • edited Loading

PabstMirror commented May 10, 2017

tbeswick96 commented May 10, 2017

tbeswick96 commented May 10, 2017

commy2 May 11, 2017

Choose a reason for hiding this comment

tbeswick96 May 11, 2017

Choose a reason for hiding this comment

commy2 May 11, 2017

Choose a reason for hiding this comment

tbeswick96 May 11, 2017

Choose a reason for hiding this comment

tbeswick96 May 11, 2017

Choose a reason for hiding this comment

tbeswick96 commented May 11, 2017 • edited Loading

tbeswick96 commented May 11, 2017 • edited Loading

bux commented May 11, 2017

kymckay May 11, 2017

Choose a reason for hiding this comment

kymckay commented May 11, 2017

PabstMirror commented May 11, 2017

jonpas May 11, 2017

Choose a reason for hiding this comment

tbeswick96 commented May 11, 2017

jonpas commented May 11, 2017 • edited Loading

PabstMirror commented May 11, 2017

tbeswick96 commented May 11, 2017 • edited Loading

tbeswick96 commented May 10, 2017 •

edited

Loading

tbeswick96 commented May 11, 2017 •

edited

Loading

tbeswick96 commented May 11, 2017 •

edited

Loading

jonpas commented May 11, 2017 •

edited

Loading

tbeswick96 commented May 11, 2017 •

edited

Loading