Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new cook off SFX #5179

Merged
merged 4 commits into from
Jun 2, 2017
Merged

Implement new cook off SFX #5179

merged 4 commits into from
Jun 2, 2017

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented May 19, 2017

When merged this pull request will:

  • Implement new cook off SFX (kindly donated by slack user hybrid_v)
  • Un-magic some numbers in cookoff with macros

I went with the 4, 5 and 6 files they shared as the others sounded a little too weak for this purpose. Note that the randomness used by CfgSFX is not synchronised in MP - I'm not sure if we care in this case.

@kymckay kymckay added kind/enhancement Release Notes: **IMPROVED:** status/needs-testing labels May 19, 2017
@kymckay kymckay added this to the 3.10.0 milestone May 19, 2017
@kymckay kymckay self-assigned this May 19, 2017
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

news sounds are good

@kymckay kymckay merged commit ae69118 into master Jun 2, 2017
@kymckay kymckay deleted the cookoffSFX branch June 2, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** status/review-pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants