[Medical Rewrite] Options to enable insta-death for AI #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31e1e29.
Arcanum417
changed the title
kymckay
added
exp/intermediate
impact/large
kind/feature
|
Merge? |
kymckay
reviewed
Dec 30, 2017
| <English>Defines if AI will be able to die instantly</English> | ||
| </Key> | ||
| <Key ID="STR_ACE_Medical_MedicalSettings_unconsciousConditionAI_DisplayName"> | ||
| <English>Forbid unconscious AI</English> |
There was a problem hiding this comment.
I feel like this setting is unnecessarily inverted, it should be "Enable AI Unconsciousness"
(However yeah we could merge and fix this in the main PR)
There was a problem hiding this comment.
Yup, descriptions and such are inverted and funky, I added the conditions in statemachine and those are kinda notes to self to remember what does it really do. The descriptions are logically correct and describe what the condition really does. The values in code should be inverted so the options could be described sensibly.
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
[Medical Rewrite] Options to enable insta-death for AI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: