Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zeus RC units using player damage treshold #5219

Merged
merged 2 commits into from
Jun 2, 2017
Merged

Fix zeus RC units using player damage treshold #5219

merged 2 commits into from
Jun 2, 2017

Conversation

Cuel
Copy link
Contributor

@Cuel Cuel commented May 30, 2017 •
edited
Loading

Closes #5218

When merged this pull request will:
Use the boolean parameter for common_isPlayer to exclude remote controlled units

@PabstMirror PabstMirror added this to the 3.10.0 milestone Jun 1, 2017
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Jun 1, 2017
@PabstMirror
Copy link
Contributor

This will work differently in rewrite, but for now I think this is reasonable.
I think we might want to use the setting GVAR(remoteControlledAI) (default: true) instead.

<English>Treat remote controlled units as AI not players?</English>

@PabstMirror PabstMirror merged commit 5b9c70a into acemod:master Jun 2, 2017
@Cuel Cuel deleted the patch-2 branch August 24, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Cuel @PabstMirror