Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aircraft Loadout Dialog #5238

Closed
wants to merge 12 commits into from
Closed

Add Aircraft Loadout Dialog #5238

wants to merge 12 commits into from

Conversation

654wak654
Copy link
Contributor

@654wak654 654wak654 commented Jun 3, 2017

When merged this pull request will:

TODO List:

  • Blacklist / Whitelist functionality.
  • Whatever the fuck that'll please the rearm overlords get this merged before ACE 3.15.0
  • Test locality.

@jonpas jonpas added this to the 3.11.0 milestone Jun 3, 2017
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add yourself to README.md and authors[].

// TODO: Header
/*
* Author: 654wak654
* Applies the current configuration of pylons to the aircraft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final dot (all functions).

@jonpas
Copy link
Member

jonpas commented Jun 9, 2017

Has been decided to add settings and add better integration with the rearm component. @654wak654 knows the plan and is working towards it.

_ctrl ctrlsetPosition [
(_picturePos select 0) + (_uiPos select 0),
(_picturePos select 1) + (_uiPos select 1),
0.100000 * safezoneW,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.100000 --> 0.1?

@Tuupertunut
Copy link
Contributor

@654wak654 What's your status on the integration with rearm component? I'm currently doing large fixes to rearming, including its pylon support. Have you changed something inside rearm? Have you encountered any bugs?

@654wak654
Copy link
Contributor Author

@Tuupertunut This little project is going to be in it's own module called pylons, which is going to be built with rearm's functions. Only local change I have so far is that I made the pylons module; haven't started to fiddle with rearm yet.

@shadez95
Copy link
Contributor

I feel like this should be a feature of CBA maybe. I'm not sure. Anyone else have thoughts on this?

@jonpas
Copy link
Member

jonpas commented Jul 18, 2017

I feel like this should be a feature of CBA maybe. I'm not sure. Anyone else have thoughts on this?

I don't think so, it's perfect for ACE3, it's not a generalized framework or anything that CBA does, it's not even a framework.

@Tuupertunut Tuupertunut mentioned this pull request Aug 8, 2017
@654wak654 654wak654 closed this Sep 14, 2017
@654wak654 654wak654 deleted the aircraft-loadouts branch September 14, 2017 15:06
@aristenn
Copy link

Does this being closed mean that we're not going to get this feature?

@sargken
Copy link
Contributor

sargken commented Sep 14, 2017

He didn't have time to finish it most likely

@jonpas
Copy link
Member

jonpas commented Sep 14, 2017

There will be a new PR opened, since it has been redesigned that much it was easier to go from start.
Source: @654wak654

@jonpas
Copy link
Member

jonpas commented Sep 16, 2017

Replaced by #5517.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:** status/invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants