Fix some event names on wiki #5254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
reviewed
Jun 6, 2017
| `AddCargoByClass` | Adds a cargo item to the vehicle. | `[_itemClass, _vehicle, _amount, _showHint]` | Local | ||
| `ace_addCargo` | [_item (CLASSNAME or OBJECT), _vehicle, _cargoCount] | Target | Scripted way to add cargo to vehicle | ||
| `ace_loadCargo` | `[_object, _vehicle, _showHint]` | Target | Load object into vehicle. | ||
| `ace_unloadCargo` | `[_object, _vehicle]` | Target | Unload object from vehicle. |
There was a problem hiding this comment.
I'd really say get rid of those "Callable" events, we should promote public functions instead (I wrote this back when I wasn't totally sure what I was doing :P).
There was a problem hiding this comment.
I agree with this, I think events should only be publicly listenable and public functions should take care of calling things where appropriate
|
Switched callable events to functions. |
jonpas
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.