Modify JoinGroup action to show group name #5287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see why anyone would have anything against that. It is information that you'd have no reason to hold back from people on the same side, and people from the opposite side shouldn't get that close to you anyways (if they can even join group from opposite side, not sure how that works). |
jonpas
reviewed
Jun 22, 2017
| * Arguments: | ||
| * 0: Target <OBJECT> | ||
| * 1: Player <OBJECT> | ||
| * 2: Args <Any> |
There was a problem hiding this comment.
<ANY>? Not sure what our standard should be for that.
jonpas
reviewed
Jun 22, 2017
| * None | ||
| * | ||
| * Example: | ||
| * [cursorObject, player, [], []] call ace_interaction_fnc_modifyJoinGroupAction; |
There was a problem hiding this comment.
No semi-colon at the end (I think that's what we decided to do... but no one put it on the wiki yet?).
jonpas
approved these changes
Jun 22, 2017
jonpas
pushed a commit
that referenced
this pull request
Jul 10, 2017
* Modify JoinGroup action to show group name * header * Header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows group name in action menu.
Edit:
I see this as a small usability improvement.
But I guess it does give some meta information about the specific group a unit is part of??
There is an ace setting
GVAR(EnableTeamManagement)that could disable the interaction if it's a problem.