Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XEH to ace_module #5304

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Add XEH to ace_module #5304

merged 1 commit into from
Jun 23, 2017

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror added this to the 3.11.0 milestone Jun 22, 2017
@PabstMirror PabstMirror requested a review from commy2 June 22, 2017 21:45
@jonpas
Copy link
Member

jonpas commented Jun 22, 2017

Won't it automatically have XEH when Module_F will get it in CBA?

@PabstMirror
Copy link
Contributor Author

I don't think so, no inheritance on

class EventHandlers {

@jonpas
Copy link
Member

jonpas commented Jun 22, 2017

Ah, good to know!

@PabstMirror PabstMirror merged commit 9bf59bc into master Jun 23, 2017
@PabstMirror PabstMirror deleted the addXehToModules branch June 23, 2017 16:32
@PabstMirror PabstMirror modified the milestones: 3.11.0, 3.10.2 Jul 8, 2017
jonpas pushed a commit that referenced this pull request Jul 10, 2017
@PabstMirror @jonpas
Add XEH to ace_module (#5304)
e6b875b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

@commy2 commy2 Awaiting requested review from commy2

Assignees
No one assigned
Labels
fault/CBA ignore-changelog Release Notes: Excluded impact/trivial
Projects
None yet
Milestone
3.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@PabstMirror @jonpas