Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Optional parameter to useEffects during setdamage/sethit #5318

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Add: Optional parameter to useEffects during setdamage/sethit #5318

merged 1 commit into from
Aug 22, 2017

Conversation

Vdauphin
Copy link
Contributor

Hello,
Since 1.67, you can skip destruction effects if you want (see : https://community.bistudio.com/wiki/setDamage and https://community.bistudio.com/wiki/setHitPointDamage https://community.bistudio.com/wiki/setHitIndex).
This is usefull in some cases where you don't want to see the vehicle explode and damage objects around (During a database loading for exemple).

This PR add an optional parameter to ace_repair_fnc_setHitPointDamage to allow this new choice.

I would know if this change is possible ?
Thanks

When merged this pull request will:

Since 1.67, you can  skip destruction effects if you want to. see  :
https://community.bistudio.com/wiki/setDamage and
https://community.bistudio.com/wiki/setHitPointDamage
This add an optional parameter  to ace_repair_fnc_setHitPointDamage to
allow this new choice
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 8, 2017
@PabstMirror PabstMirror added this to the 3.11.0 milestone Jul 8, 2017
@PabstMirror
Copy link
Contributor

This looks good, do you have a use case for the new param?

@jonpas
Copy link
Member

jonpas commented Jul 8, 2017

It's not a public function, is that param used within ACE3 anywhere?

@Vdauphin
Copy link
Contributor Author

Vdauphin commented Jul 8, 2017

Hello,

do you have a use case for the new param?

[vehicle, 1, 0.5, true] call ace_repair_fnc_setHitPointDamage
Should I change the actual exemple with this one ?

is that param used within ACE3 anywhere?

@jonpas I don't know. I am using this function to set damage to vehicle saved from a database.

@PabstMirror PabstMirror merged commit c3986b0 into acemod:master Aug 22, 2017
@Vdauphin Vdauphin deleted the Add-useEffects_option_damage branch August 22, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants