-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookoff - Improve ammo detonation sounds #5327
Conversation
I failed to see that this was for the ammo cook offs |
I am currently working to Implement an Object Pooling Solution and LAxemann is not 100% happy with the sounds and may change them a bit. |
improve Distances
Pushing back to 3.12.0, would like to see more discussion on this versus old system. |
The new variant sounds good, but I do not know how the old one was. |
The old.system had no sound modulation on distances so it sounded like the explosion was close even when that was not the case |
And no SOS calculation so a rocket explosion sound was by the player at the moment of creation, of the sound object. The new system now have 3 steps for modulation of the sound and also uses a correct sos timing |
The old sounds also clipped what created kind of white noice |
change random Distance add
Pushing this milestone back in favour of getting 3.12.0 out the door, significant changes that require some further review. Is there any performance impact associated with this? I've always been a little dubious about the whole creating objects for sound addons thing, but never properly looked into it. |
we should take the sounds but not the code from this PR. |
I do not think that that is possible because the sounds are made to change at different distances and playSound3D does not support that at all. |
the new ones sounds way much better is this still WIP? |
I wanted to implement this using CBATeam/CBA_A3#1174 which is not finished. |
@commy2 maybe this PR should be merged and when CBA implementation is ready it can be edited? |
But I don't like this implementation. |
Anyone wants to do anything with this? |
I think it would be neat. I need to take a better look at it once I have cleared my backlog. |
I went ahead and pushed my suggestions after testing. The sounds might not be loud enough in its current implementation, but that can be easily tweaked via |
In the latest commit I bumped the volume from 1 to 2. |
When merged this pull request will:
that I used within Enhanced SoundScape.
Demo:
https://www.youtube.com/watch?v=WyjK5lZIuD4&feature=youtu.be
the Version in the video not 100% of the same random values because the current values fit better
Sounds by LAxemann