Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Remove Wheel" Action's Color Based on Damage #5415

Merged
merged 2 commits into from
Aug 10, 2017
Merged

Change "Remove Wheel" Action's Color Based on Damage #5415

merged 2 commits into from
Aug 10, 2017

Conversation

654wak654
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Sometimes I have to remove all 6 wheels of the Otokar Arma to find which 2 were effected by an RPG hit 😢.

Screenshots: http://imgur.com/a/N1SgY

@654wak654 654wak654 changed the title Change "Remove Wheel" Action's Colors Based on Wheel Damage Change "Remove Wheel" Action's Colors Based on Damage Aug 9, 2017
@654wak654 654wak654 changed the title Change "Remove Wheel" Action's Colors Based on Damage Change "Remove Wheel" Action's Color Based on Damage Aug 9, 2017
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming you used same colors as for wheels themselves?

@@ -0,0 +1,32 @@
/*
* Author: 654wak654
* Modifies interaction color of vehicle selection to show it's current damage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final dot. its current damage.

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Aug 9, 2017
@jonpas jonpas added this to the 3.11.0 milestone Aug 9, 2017
@654wak654
Copy link
Contributor Author

654wak654 commented Aug 9, 2017

I am assuming you used same colors as for wheels themselves?

Yup, exact same color as the damage_X images

@jonpas
Copy link
Member

jonpas commented Aug 10, 2017

Do other repair points use similar levels of damage that this could be added to? I am thinking all points could use this in that case.

@654wak654
Copy link
Contributor Author

654wak654 commented Aug 10, 2017

Do other repair points use similar levels of damage that this could be added to? I am thinking all points could use this in that case.

Thought of the same thing but it's less useful with other hitpoints, since their action doesn't show up unless they're damaged anyway.

To answer the question though: Yes, you could just add FUNC(modifySelectionInteraction) to those actions and they'd work the same way.

@jonpas
Copy link
Member

jonpas commented Aug 10, 2017

You are right, little point since they show up only when damaged, additionally their hitpoints are shown in when you sit in the vehicle.

@jonpas jonpas merged commit ff1247d into acemod:master Aug 10, 2017
@654wak654 654wak654 deleted the repair-colors branch August 12, 2017 11:05
@jonpas jonpas mentioned this pull request Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants