Added fastrope keybind #5606
Merged
Added fastrope keybind #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaerMitUmlaut
added
impact/trivial
kind/enhancement
PabstMirror
reviewed
Oct 10, 2017
addons/fastroping/XEH_postInit.sqf
Outdated
| @@ -8,6 +8,16 @@ | |||
| [FUNC(fastRopeServerPFH), 0, _this] call CBA_fnc_addPerFrameHandler; | |||
| }] call CBA_fnc_addEventHandler; | |||
|
|
|||
| // Keybinds | |||
| ["ACE3 Vehicles", QGVAR(fastRope), localize LSTRING(Interaction_fastRope), { | |||
| if ([ACE_player, vehicle ACE_player] call FUNC(canFastRope)) then { | |||
There was a problem hiding this comment.
I think we might want the following (probably don't need the in-vehicle check, but can't hurt)
if ((vehicle ACE_player) == player) exitWith {false};
if (!([ACE_player, vehicle ACE_player, []] call EFUNC(common,canInteractWith))) exitWith {false};
There was a problem hiding this comment.
Didn't you mean (vehicle ACE_player) == ACE_player?
PabstMirror
approved these changes
Oct 12, 2017
|
I don't mean to feature creep, but could it possibly be made so that helicopter pilots are able to initiate a fast roping sequence and force people out? There's always that guy in the back who can't find the menu option when scrolling or who hasn't set the fast roping keybind. |
|
No. |
|
oops, thanks bär |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: