Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS 3.4 Goggles and AB Ammo compat update #5607

Merged
merged 3 commits into from
Oct 11, 2017

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Oct 11, 2017

Adds the new Oakley SI Ballistics googles and the googles integrated into the new shemags.
Also add's M855 Ammo which is the same as M855A1 because our A1 data is incorrect. But it doesn't matter that it's incorrect. The difference is too small to matter for such a short-range round.
The rhs_ess_black is not new in 3.4 as far as I can see. But it was missing.

@@ -40,7 +40,19 @@ class CfgAmmo {
ACE_barrelLengths[] = {508.0, 609.6, 660.4};
};
class B_556x45_Ball;
class rhs_ammo_556x45_M855A1_Ball: B_556x45_Ball { // B_556x45_Ball (ballistics/CfgAmmo.hpp)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I wish diffing algo's were a little better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the line break.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to be LF. Either it was CRLF or you changed it to it, either way .gitattributes apparently doesn't catch all configurations. :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is CRLF in my file (o_o)/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw .gitattributes doesn't say that it will convert to anything.
I see editorConfig says LF.. But the .editorconfig is using CRLF itself..
I guess that's just autocrlf doing stuff...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's autocrlf, Git will automatically convert to LF as by .gitattributes, you won't see those messages if you are using autocrlf because that's the point of autocrlf.

And yes, it obviously does say: * text=auto. The whole point is that it doesn't matter what your local files are using, they should always be LF on the server (GitHub), although we had an occasion in the past that it somehow slipped through, but it seemed to be because of editing directly on GitHub.

@jonpas jonpas added this to the 3.11.0 milestone Oct 11, 2017
@jonpas jonpas added area/compatibility kind/enhancement Release Notes: **IMPROVED:** labels Oct 11, 2017
@PabstMirror PabstMirror merged commit b51adce into acemod:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compatibility kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants