Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat for RHS 0.4.3 new vehicles #5619

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • add Ural Repair and FMTV Rearm/Refuel/Repair;
  • replace era_*_hitpoint elements with macros;
  • fix t72bd ERA config;
  • add missing T-80 and M2A2 ERA grouping configs.

It looks like it's better/simpler to create 1 big enough ERA grouping array (e.g. 100 elements) and not mess with exact ERA hitpoints count.

In fact rhsusf_M1078A1R_SOV_M2_D_fmtv_socom is not real refuel vehicle, so I made refuel hook at most appropriate (for me) place.

@PabstMirror PabstMirror added area/compatibility kind/cleanup Release Notes: **CHANGED:** labels Oct 14, 2017
@PabstMirror PabstMirror added this to the 3.11.0 milestone Oct 14, 2017
@Neviothr
Copy link
Contributor

Shouldn't #defines be in script_component.hpp?

@Dystopian
Copy link
Contributor Author

these macros are very specific for corresponding classes, so I decided not to move them far.

@PabstMirror PabstMirror merged commit f6fd009 into acemod:master Oct 14, 2017
@Dystopian Dystopian deleted the add_RHS_043 branch October 14, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compatibility kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants