Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATragMX and RangeCard - Fixed incorrect MRAD conversions #5640

Merged
merged 1 commit into from
Oct 20, 2017
Merged

ATragMX and RangeCard - Fixed incorrect MRAD conversions #5640

merged 1 commit into from
Oct 20, 2017

Conversation

ulteq
Copy link
Contributor

@ulteq ulteq commented Oct 20, 2017

  • This greatly improves the accuracy of the MRAD output in both modules
  • Old and incorrect conversion factor: 3.38 [(360 * 60) / 6400]
  • New and correct conversion factor: 3.44 [54 / (5 * PI)]

@ulteq
ATragMX and RangeCard - Fixed incorrect MRAD conversions
7bbba22 
- This greatly improves the accuracy of the MRAD output in both modules
- Old and incorrect conversion factor: 3.38 [(360 * 60) / 6400]
- New and correct conversion factor: 3.44 [54 / (5 * PI)]
@ulteq ulteq added the kind/bug-fix Release Notes: **FIXED:** label Oct 20, 2017
@ulteq ulteq added this to the 3.11.0 milestone Oct 20, 2017
bux
bux previously requested changes Oct 20, 2017
View reviewed changes
Copy link
Member

@bux bux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change target into release branch

@jonpas
Copy link
Member

jonpas commented Oct 20, 2017

Merging into master is fine. I will pull master in for another build today evening.

Or at least release-3.11.0, not release.

@jonpas jonpas dismissed bux’s stale review October 20, 2017 15:33

Not exactly gitflow, but easier to just pull from master right now as nothing else was committed.

@jonpas jonpas merged commit 923507d into master Oct 20, 2017
@jonpas jonpas deleted the mrad-conversion-fix branch October 20, 2017 15:33
ulteq added a commit that referenced this pull request Oct 21, 2017
@ulteq
Scopes - Fixed MRAD conversion
6f5d7df 
* Same issue as #5640
@ulteq ulteq mentioned this pull request Oct 21, 2017
Merged
ulteq added a commit that referenced this pull request Oct 22, 2017
@ulteq
Scopes - Fixed MRAD conversion (#5651)
3484942 
* Same issue as #5640
@ThiagoGattiCarvalho
Copy link

Source | Circle [MIL] | 1 MOA = | 1 MIL =
Russians | 6000.00 | 0.27777778 MIL | 3.60000000 MOA
NATO | 6400.00 | 0.29629630 MIL | 3.37500000 MOA
USMC | 6283.00 | 0.29087963 MIL | 3.43784816 MOA
Swedish | 6300.00 | 0.29166667 MIL | 3.42857143 MOA
Trigonometry | 6283.19 | 0.29088821 MIL | 3.43774677 MOA

@ulteq
Copy link
Contributor Author

ulteq commented Oct 24, 2017

JBM Ballistics and Strelok both seem to be using 3.43774677, which is what we now use, to avoid further confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

@bux bux bux left review comments

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ulteq @jonpas @ThiagoGattiCarvalho @bux