AB compat rail/scope height update #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ulteq What is WIP on this? Besides adding all the NPZ classes which I don't plan on doing. |
This, but I guess we could also insert them later with a separate PR. |
|
Yeah. This is just a update to improve the existing compat. IMO the RHS compat should be completly overhauled. checking if inheritance is still correct. and really adding all the missed classes |
PabstMirror
approved these changes
Oct 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compat variant of #5648
I only updated the weapons we already had in compat and only added new ones were really necessary.
I noticed we are missing all RHS AK variants with NPZ which have a different railheight that the non-NPZ ones.
If someone else want's to add the missing stuff here is a table of all rail heights: https://docs.google.com/spreadsheets/d/1d5O_nC0Cq26CWGI4sqjZU9jdhArV5pkSm-VMDT7uvM4/edit?usp=sharing