Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(spectator) unhide/unmute unit on exiting #5699

Merged
merged 2 commits into from
Oct 28, 2017
Merged

Conversation

Cuel
Copy link
Contributor

@Cuel Cuel commented Oct 28, 2017

When merged this pull request will:

  • unmute/unhide player when exiting spectator

previously doing [true] call ace_spectator_fnc_setSpectator and then [false] call ace_spectator_fnc_setSpectator would result in a hidden player

I'm not entirely sure this is the best way. What if the player is dead when exiting?

@jonpas jonpas requested a review from kymckay October 28, 2017 13:37
@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Oct 28, 2017
@jonpas jonpas added this to the 3.12.0 milestone Oct 28, 2017
@kymckay
Copy link
Member

kymckay commented Oct 28, 2017

Good catch 👍 You should be using the _hidden variable though

@PabstMirror PabstMirror merged commit c815a9c into acemod:master Oct 28, 2017
@Cuel Cuel deleted the patch-2 branch October 28, 2017 17:23
Fusselwurm pushed a commit to Fusselwurm/ACE3 that referenced this pull request Nov 18, 2017
* unhide/unmute unit on exiting

* Update fnc_setSpectator.sqf
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* unhide/unmute unit on exiting

* Update fnc_setSpectator.sqf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants