Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopes - Adds simplified zeroing subsystem #5787

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Scopes - Adds simplified zeroing subsystem #5787

merged 1 commit into from
Nov 29, 2017

Conversation

ulteq
Copy link
Contributor

@ulteq ulteq commented Nov 17, 2017 •
edited
Loading

  • Client side setting to choose the preferred zeroing method
  • Replicates the behavior of the vanilla zeroing system

This allows you to zero your scope in 50 meter increments if you don't like the current adjustment turrets.

@ulteq ulteq added the kind/enhancement Release Notes: **IMPROVED:** label Nov 17, 2017
@ulteq ulteq added this to the 3.12.0 milestone Nov 17, 2017
@ulteq ulteq modified the milestones: 3.12.0, 3.13.0 Nov 17, 2017
@ulteq ulteq added kind/feature Release Notes: **ADDED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels Nov 17, 2017
@PabstMirror
Copy link
Contributor

PabstMirror commented Nov 17, 2017 •
edited
Loading

Close #5039 (Gives the user an experience much more like vanilla zeroing)
Also, I think this shouldn't be user settable as it's more of a difficulty setting imho

@ulteq
Copy link
Contributor Author

ulteq commented Nov 17, 2017 •
edited
Loading

Also, I think this shouldn't be user settable as it's more of a difficulty setting

Agreed.

@ulteq ulteq force-pushed the scopes-optional-vanilla-zeroing branch 2 times, most recently from 4179965 to c2a86a6 Compare November 18, 2017 18:04
@ulteq ulteq modified the milestones: 3.13.0, 3.12.0 Nov 18, 2017
@ulteq ulteq added kind/feature kind/feature Release Notes: **ADDED:** and removed kind/feature Release Notes: **ADDED:** kind/feature labels Nov 19, 2017
@PabstMirror PabstMirror mentioned this pull request Nov 21, 2017
Closed
@ulteq
Scopes - Adds simplified zeroing subsystem
4f13e54 
* Client side setting to choose the preferred zeroing method
* Replicates the behaviour of the vanilla zeroing system
@ulteq ulteq force-pushed the scopes-optional-vanilla-zeroing branch from c2a86a6 to 4f13e54 Compare November 22, 2017 20:13
PabstMirror
PabstMirror approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ulteq ulteq merged commit 09c3187 into master Nov 29, 2017
@ulteq ulteq deleted the scopes-optional-vanilla-zeroing branch November 29, 2017 10:38
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@ulteq
Scopes - Adds simplified zeroing subsystem (#5787)
fe5daaa 
* Client side setting to choose the preferred zeroing method
* Replicates the behaviour of the vanilla zeroing system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees

@PabstMirror PabstMirror

Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ulteq @PabstMirror