Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Movement - Fix climbing when over water #5800

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Movement - Fix climbing when over water #5800

merged 1 commit into from
Nov 21, 2017

Conversation

PabstMirror
Copy link
Contributor

Fix #5795

Before: 
AGLtoASL _pos=[2452.95,6470.46,24.9426], getPosASL _unit=[2452.95,6470.46,49.5334] z\ace\addons\movement\functions\fnc_handleClimb.sqf:29

After: 
AGLtoASL _pos=[2453,6470.63,24.9413], getPosASL _unit=[2453,6470.63,24.9413] z\ace\addons\movement\functions\fnc_handleClimb.sqf:29

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Nov 21, 2017
@PabstMirror PabstMirror added this to the 3.12.0 milestone Nov 21, 2017
@commy2
Copy link
Contributor

commy2 commented Nov 21, 2017

lgtm, but doesn't setPos already use PosAGL? Or did they fuck it up somehow?

@ulteq
Copy link
Contributor

ulteq commented Nov 21, 2017

_unit setPosATL _pos; does not work?

@PabstMirror
Copy link
Contributor Author

I'm honestly not sure, it seems like setPos is adding the carrier's deck height.
and I think setPosATL could put you underwater

@commy2 commy2 merged commit a3a0d23 into master Nov 21, 2017
@commy2 commy2 deleted the fixClimbingOnWater branch November 21, 2017 19:09
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@commy2
Merge pull request #5800 from acemod/fixClimbingOnWater
911dfff 
Movement - Fix climbing when over water
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulteq ulteq ulteq approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @commy2 @ulteq