Advanced Ballistics - Removed all unnecessary settings #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulteq
force-pushed
the
advanced-ballistics-settings-overhaul
branch
from
b6f31b2
to
6ae8c21
Compare
PabstMirror
reviewed
Nov 28, 2017
| }; | ||
| if (ACE_player distance _unit > _maxRange && {ACE_player distance ((getPosASL _unit) vectorAdd ((vectorNormalized _bulletVelocity) vectorMultiply _maxRange)) > _maxRange}) exitWith {}; | ||
|
|
||
| private _ammoCount = _unit ammo _muzzle; |
There was a problem hiding this comment.
I think we want to add +1 here as first shot is 29 and last is 0 (the ammo is already removed by the time firedEH runs)
PabstMirror
reviewed
Nov 28, 2017
| if (_ammoCount <= _lastRoundsTracer || {_tracersEvery > 0 && {(_ammoCount - _lastRoundsTracer) % _tracersEvery == 0}}) exitWith { _abort = false }; | ||
|
|
||
| if (GVAR(bulletTraceEnabled) && {_muzzleVelocity > BULLET_TRACE_MIN_VELOCITY} && {cameraView == "GUNNER"}) then { | ||
| if (currentWeapon ACE_player == binocular ACE_player) exitWith { _abort = false }; |
There was a problem hiding this comment.
I guess a civilian driving a tank could have cameraView gunner and currentWeapon ACE_player == binocular ACE_player (both "")
but I wouldn't worry about it
There was a problem hiding this comment.
We could check if the player is currently sitting in a vehicle. But then we would need extra code for the spotting scope.
An ideal solution would be to only display the bullet trace if the view is magnified at least 4 times.
There was a problem hiding this comment.
We can always refine this later, I wouldn't bother changing it for now
* It just works automagically
ulteq
force-pushed
the
advanced-ballistics-settings-overhaul
branch
from
6ae8c21
to
332bd46
Compare
PabstMirror
approved these changes
Nov 30, 2017
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* It just works automagically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
simulateForSnipers,simulateForGroupMembers,simulateForEveryone,disabledInFullAutoModeandsimulationRadiuswith some automagic.Advanced Ballistics is now only running if:
a) The projectile is local
b) The projectile is a tracer (or has a visible bullet trace effect) and is reasonably close to the player