-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace usage of setCaptive with camouflageCoef trait #5864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a much better approach for compatibility
Realised this affects captives module too, should add new event for camouflage
Tested a bit in mp
With setCaptive, it's like you turn into a friendly civ, so they probably actively try not to shoot at you or splash you with frag. I actually think that might be an improvement and be more realistic. |
The hearing you part could maybe be fixed by also setting |
For the cause of unconscious I don't think hearing you is an issue since you can't move anyway |
This made me still get shoot by the enemy,When I lost consciousness in front of the him |
@carlosleung Please don't revive old issues and pull requests. |
This just reimplemented the behaviour from #5864 I believe we though using `setUnconscious` command would make this unnecessary, but testing seems to show that's not the case
This just reimplemented the behaviour from #5864 I believe we though using `setUnconscious` command would make this unnecessary, but testing seems to show that's not the case
replace usage of setCaptive with camouflageCoef trait
When merged this pull request will: