Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endRadioTransmissions Event #5873

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Add endRadioTransmissions Event #5873

merged 2 commits into from
Dec 8, 2017

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Dec 8, 2017

Add's ACE_endRadioTransmissions Event that can be hooked by other Radio mods.

The TFAR code causes Problems in combination with spectator. TFAR 1.0 has a new function that handles that but I don't want to keep adding a TFAR 1.0 check into here and modify this everytime something changes. So I just added one Event for all Radio mods.

Also calling TFAR_fnc_onDDTangentReleased will throw a deprecation warning with 1.0. So the old code should be removed once the new version is released and properly gained traction.

@@ -16,6 +16,8 @@
*/
#include "script_component.hpp"

[QGVAR(endRadioTransmissions)] call CBA_fnc_localEvent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public events should be "ace_X".

@PabstMirror
Copy link
Contributor

could add something like this if the calls would be a problem

private _tfrVersionAr = getArray (configFile >> "CfgPatches" >> "task_force_radio" >> "versionAr");
if ([[1], _tfrVersionAr] call cba_versioning_fnc_version_compare) exitWith {};

@PabstMirror PabstMirror added this to the 3.12.0 milestone Dec 8, 2017
@PabstMirror PabstMirror added area/compatibility kind/enhancement Release Notes: **IMPROVED:** labels Dec 8, 2017
@dedmen
Copy link
Contributor Author

dedmen commented Dec 8, 2017

Can detect 1.0 with CfgPatches class tfar_core It's just a warning message in RPT.
And it's only for the DD one. The other stuff is still needed for 1.0 versions before this event is added.

@PabstMirror PabstMirror merged commit 18d4b96 into acemod:master Dec 8, 2017
@dedmen dedmen deleted the patch-4 branch December 10, 2017 12:38
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Add endRadioTransmissions Event

* Update fnc_endRadioTransmission.sqf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compatibility kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants