Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ammoCount ui element changeable despite ace_reload #5877

Closed
wants to merge 1 commit into from

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Dec 9, 2017

I think making this not changeable when a component is present is unnecessarily confusing.

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label Dec 9, 2017
@PabstMirror
Copy link
Contributor

PabstMirror commented Dec 9, 2017

We need this to show ammo count while controlling UAVs
see #5222

@jonpas
Copy link
Member

jonpas commented Jan 22, 2018

I wrote something like this on Slack, but then forgot to paste it here. The point of Selective UI is it being selective yes, but ACE3's goal is still realism, and by accepting this PR we would allow anyone to just show the Reload UI, which goes against why that component even exists:

Hides the default reload indicators, making it necessary to manually check your magazine.

This still allows people to remove the PBO and get ability to set it themselves. Additionally using that config it could (and probably should) be made into a setting (enable/disable component) instead, so you wouldn't even have to remove the PBO, and it will all nicely hook with Selective UI as well.

I believe @commy2 agreed after I explained that, and is required for reason @PabstMirror stated above, so closing this.

@jonpas jonpas closed this Jan 22, 2018
@jonpas jonpas deleted the ammoCount-editable-despite-reload-component branch January 22, 2018 22:20
@ghost
Copy link

ghost commented Oct 1, 2020

If this is forced why even have the option to enable or disable it in options? And why force it if its outright removing an UI element that was in the base game?

@jonpas
Copy link
Member

jonpas commented Oct 1, 2020

Because you can remove the reload PBO.

@ghost
Copy link

ghost commented Oct 2, 2020

Wouldn't that make incompatibility with people that have the reload PBO on servers? And why not just disable it through the ingame options?

@jonpas
Copy link
Member

jonpas commented Oct 2, 2020

What incompatibility? You should run the same PBOs on server and all clients.

I am not sure what you mean with your last question.

@ghost
Copy link

ghost commented Oct 2, 2020

What i mean is that if having no reload PBO on a server people with the reload PBO would be able to join. Since i cant force an UI setting on the players.
The question was about why even have the option to enable/disable the ammo counter if it doesn't work and i have to delete a PBO to make it appear.

@jonpas
Copy link
Member

jonpas commented Oct 2, 2020

Enable CheckPBOs. I already explained why, ACE is modular, you can do whatever you like with it, we only provide sensible defaults.

Now let's stop resurrecting old tickets and move questions like this to Slack.

@ghost
Copy link

ghost commented Oct 2, 2020

I realize that its modular, i just dont understand why enabling and disabling PBOs are required just because a setting in the options for the UI is bugged.

@jonpas
Copy link
Member

jonpas commented Oct 2, 2020

It is not bugged.

@ghost
Copy link

ghost commented Oct 3, 2020

Then why does changing the obvious setting in ACE UI to show me the ammo left in the mag doesn't work?

@commy2
Copy link
Contributor Author

commy2 commented Oct 3, 2020

This should've just been merged imo.

@jonpas
Copy link
Member

jonpas commented Oct 3, 2020

Because you have the reload PBO loaded, which works on top of UI, like any mod can. It even tells you why it locked and source in RPT. This has been explained in this topic a few times now, end of discussion.

@ghost
Copy link

ghost commented Oct 3, 2020

And there is no plan to fix the obvious issue that with the reload PBO loaded the settings wont display the ammo counter yet the option wont be removed because its obviously a bug?

@jonpas
Copy link
Member

jonpas commented Oct 3, 2020

It's not a bug, it is by design. Remove the reload PBO if you don't want it. With standard ACE package you can't change it, with custom variations (without reload PBO) you can - by design.

If you want to discuss this further, join Slack, I am locking this ticket from 2018, things have been explained.

@acemod acemod locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants