Arsenal - Filter items with scopeArsenal = 0

[PabstMirror]

Fix #5983

Uses same logic as bis's arsenal
_scope = if (isnumber (_class >> "scopeArsenal")) then {getnumber (_class >> "scopeArsenal")} else {getnumber (_class >> "scope")};

What gets filtered with my modset:

rhs_weap_ak74m_zenitco01_npz [2:0]
rhs_weap_ak74m_zenitco01_npz_grip1 [2:0]
rhs_weap_ak74m_zenitco01_npz_afg [2:0]
rhs_weap_ak105_zenitco01_npz [2:0]
rhs_weap_ak105_zenitco01_npz_grip1 [2:0]
rhs_weap_ak105_zenitco01_npz_afg [2:0]
rhs_weap_ak104_zenitco01_npz [2:0]
rhs_weap_ak104_zenitco01_npz_grip1 [2:0]
rhs_weap_ak104_zenitco01_npz_afg [2:0]
rhs_weap_ak103_zenitco01_npz [2:0]
rhs_weap_ak103_zenitco01_npz_grip1 [2:0]
rhs_weap_ak103_zenitco01_npz_afg [2:0]
rhs_weap_ak74m_dtk [2:0]
rhs_weap_ak105_pgs64 [2:0]
hlc_rifle_G36A1_CMAG [2:0]
hlc_rifle_G36A1AG36_CMAG [2:0]
hlc_rifle_MG36_30rnd [2:0]
hlc_rifle_G36KA1_CMAG [2:0]
hlc_rifle_G36c_CMAG [2:0]
hlc_rifle_G36E1_CMAG [2:0]
hlc_rifle_G36E1AG36_CMAG [2:0]
hlc_rifle_G36E1AG36_Romi_CMAG [2:0]
hlc_rifle_G36KE1_CMAG [2:0]
hlc_rifle_G36V_CMAG [2:0]
hlc_rifle_G36KV_CMAG [2:0]
hlc_rifle_G36cV_CMAG [2:0]
hlc_rifle_G36VAG36_CMAG [2:0]
hlc_rifle_G36KA1KSK_CMAG [2:0]
HLC_Rifle_G36KSKAG36_CMAG [2:0]
hlc_rifle_G36TAC_CMAG [2:0]
hlc_rifle_g36KTac_CMAG [2:0]
hlc_rifle_G36CTac_CMAG [2:0]
hlc_rifle_g3sg1_XMAG [2:0]
hlc_rifle_g3sg1ris_XMAG [2:0]
hlc_rifle_psg1_XMAG [2:0]
hlc_rifle_psg1A1_XMAG [2:0]
hlc_rifle_PSG1A1_RIS_XMAG [2:0]
hlc_rifle_g3a3_XMAG [2:0]
hlc_rifle_g3a3ris_XMAG [2:0]
hlc_rifle_g3a3v_XMAG [2:0]
hlc_rifle_g3a3vris_XMAG [2:0]
hlc_rifle_g3ka4_XMAG [2:0]
HLC_Rifle_g3ka4_GL_XMAG [2:0]
hlc_rifle_hk51_XMAG [2:0]
ACE_key_master [2:0]
ACE_key_lockpick [2:0]
ACE_key_west [2:0]
ACE_key_east [2:0]
ACE_key_indp [2:0]
ACE_key_civ [2:0]
CUP_U_B_GER_Ghillie [2:0]
CUP_U_B_GER_Fleck_Ghillie [2:0]
CUP_H_SLA_Pilot_Helmet [2:0]
CUP_U_O_TK_Ghillie [2:0]
CUP_U_B_USArmy_Ghillie [2:0]
CUP_U_B_USMC_Ghillie_WDL [2:0]
CUP_U_B_BAF_MTP_Ghillie [2:0]

[jonpas]

@alganthe

[commy2]

Why is the 2 == in front? That looks so weird.

[Cuel]

yoda condition 😃

[Dystopian]

I usually use this form, kind short == very_long_expression, it's much easier to see what is checked here.

[dedmen]

As I said though this ignores items with scope!=2 and scopeArsenal==2.
Checking both is ofcause a tiny bit slower (lazy eval) but this runs once at gameStart soo..

[alganthe]

Go for it :/

[kymckay]

Runs once upon game launch so performance impact is negligible; consistency with vanilla arsenal is desired.