Add parentheses to GETVAR macros #5995
Conversation
| @@ -37,7 +37,7 @@ | |||
| #define GETGVAR(var1,var2) GETMVAR(GVAR(var1),var2) | |||
| #define GETEGVAR(var1,var2,var3) GETMVAR(EGVAR(var1,var2),var3) | |||
|
|
|||
| #define ARR_SELECT(ARRAY,INDEX,DEFAULT) if (count ARRAY > INDEX) then {ARRAY select INDEX} else {DEFAULT} | |||
| #define ARR_SELECT(ARRAY,INDEX,DEFAULT) (if (count ARRAY > INDEX) then {ARRAY select INDEX} else {DEFAULT}) | |||
There was a problem hiding this comment.
(ARRAY param [INDEX, DEFAULT])
There was a problem hiding this comment.
Could also remove ARR_SELECT which only has 1 use:
https://github.com/acemod/ACE3/search?utf8=%E2%9C%93&q=ARR_SELECT&type=
There was a problem hiding this comment.
ACE's macros aren't supposed to be used by others, specially not one this archaic.
There was a problem hiding this comment.
Actually they are: https://github.com/acemod/arma-project-template/blob/master/addons/main/script_macros.hpp
But this one can safely be removed as it plays no role anymore.
There was a problem hiding this comment.
I mean, it can also stay as is. Doesn't have to be removed with this PR. I'm for merging this PR.
There was a problem hiding this comment.
OK, will not update it
Add parentheses to GETVAR macros
When merged this pull request will:
GETVARandARR_SELECTmacros;