add allowFadeMusic setting #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kymckay
reviewed
Jan 2, 2018
addons/common/stringtable.xml
Outdated
| @@ -1151,5 +1151,13 @@ | |||
| <Chinesesimp>重量:</Chinesesimp> | |||
| <Chinese>重量:</Chinese> | |||
| </Key> | |||
| <Key ID="STR_ACE_Common_AllowFadeMusic"> | |||
| <English>Allow muting music</English> | |||
There was a problem hiding this comment.
Are we muting the music though? I think it'd be a bit clearer like "Allow music volume adjustment"
There was a problem hiding this comment.
You're right. I read 0 fadeMusic wrong.
kymckay
approved these changes
Jan 2, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
add allowFadeMusic setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Couldn't push to remote branch, so 2nd PR it is...