NVG - Fix grain and color effects #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kymckay
reviewed
Jan 4, 2018
|
|
||
| GVAR(ppEffectCCMuzzleFlash) ppEffectAdjust [1, 1, 0, [0, 0, 0, 0], [0, 0, 0, 1], [0, 0, 0, 1]]; | ||
| GVAR(ppEffectCCMuzzleFlash) ppEffectCommit 0.07; | ||
| QGVAR(cutoff) cutText ["", "BLACK", .1]; |
There was a problem hiding this comment.
If we wanted to make it slightly more realistic perhaps we could make use of WHITE OUT here in the cutText
There was a problem hiding this comment.
I should also point out in my experience that the speed parameter listed on biki is actually more like the length of time it's shown for
There was a problem hiding this comment.
"test" cutText ["", "BLACK", 5]; will fade from transparent to black over 5 second and stay that way
There was a problem hiding this comment.
Ah okay, I guess it's length of time when it's "PLAIN"
jonpas
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6017 - Delete grain effect when opening escape menu in SP
Fix #5961 - Just use
cutText