Fix back blast if damage not allowed #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good catch |
commy2
reviewed
Jan 7, 2018
| TRACE_1("",isDamageAllowed _x); | ||
| if (!isDamageAllowed _x) exitWith {}; // Skip damage if not allowed | ||
| TRACE_1("",isDamageAllowed _unit); | ||
| if (!isDamageAllowed _unit) exitWith {}; // Skip damage if not allowed | ||
| _unit setDamage (damage _unit + _damage); |
There was a problem hiding this comment.
Any reason this is an exitWith when it could be a then for simplicity?
There was a problem hiding this comment.
I like exitWith :)
There was a problem hiding this comment.
Same. But I like classical control structures even more.
There was a problem hiding this comment.
classical one makes too many indents
There was a problem hiding this comment.
I think I might have just been trying to minimize the git diff, which isn't really a good reason
PabstMirror
approved these changes
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.