Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix house-type object carrying in building #6049

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

Dystopian
Copy link
Contributor

If you carry "house" type object (like Portable light) inside building and drop it, it will be aligned to terrain level instead of building floor. This can be avoided with lineIntersectsSurfaces using.

This is #3497 partial rewrite.

@jonpas
Copy link
Member

jonpas commented Jan 14, 2018

Tested underwater? It was specifically changed to use ATL position for that reason.

@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Jan 14, 2018
@Dystopian
Copy link
Contributor Author

Tested, works.
And exactly when it was changed to ATL it was broken :P

@jonpas
Copy link
Member

jonpas commented Jan 15, 2018

It was a lot more broken before, because it didn't work at all underwater! :p

@jonpas jonpas added this to the 3.12.1 milestone Jan 15, 2018
@jonpas jonpas merged commit 70ca4d0 into acemod:master Jan 15, 2018
@Dystopian Dystopian deleted the fix_drop_lamp_in_building branch January 15, 2018 20:22
@Cuel
Copy link
Contributor

Cuel commented Jan 16, 2018

Wasn't it changed for ships?

@Dystopian
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants