-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seperate setting for NVG noise intensity #6059
Conversation
Should it not be a client setting in that case? Should also be added via CBA Settings directly. |
No, because it's also a difficulty option. |
All, and use |
That's not the point of this PR and should be done in a seperate one. Small, granular changes. |
Sure, but before next release then. Less |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but should be moved to CBA Settings directly (along with other settings in this component) before next release.
Not approving as I'd like @PabstMirror to take a look too.
Conflicts: addons/nightvision/stringtable.xml
When merged this pull request will:
A seperate setting for this makes sense as it can cause headaches with long time use. The other effects do not cause this issue. Was also requested in #3594 by @ghost.