Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seperate setting for NVG noise intensity #6059

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Conversation

BaerMitUmlaut
Copy link
Member

When merged this pull request will:

  • Add a seperate setting for NVG noise intensity

A seperate setting for this makes sense as it can cause headaches with long time use. The other effects do not cause this issue. Was also requested in #3594 by @ghost.

@BaerMitUmlaut BaerMitUmlaut added the kind/enhancement Release Notes: **IMPROVED:** label Jan 17, 2018
@jonpas
Copy link
Member

jonpas commented Jan 17, 2018

Should it not be a client setting in that case?

Should also be added via CBA Settings directly.

@BaerMitUmlaut
Copy link
Member Author

No, because it's also a difficulty option.
I don't think it's a good idea to have half CBA, half ACE settings. Either convert all or none.

@jonpas
Copy link
Member

jonpas commented Jan 17, 2018

Either convert all or none.

All, and use movedToSQF like in markers.

@BaerMitUmlaut
Copy link
Member Author

That's not the point of this PR and should be done in a seperate one. Small, granular changes.

@jonpas
Copy link
Member

jonpas commented Jan 17, 2018

Sure, but before next release then. Less movedToSQF the better. Doesn't matter during development as we obviously don't provide backwards compatibility that time.

@jonpas jonpas added this to the 3.13.0 milestone Jan 22, 2018
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should be moved to CBA Settings directly (along with other settings in this component) before next release.

Not approving as I'd like @PabstMirror to take a look too.

 Conflicts:
	addons/nightvision/stringtable.xml
@PabstMirror PabstMirror merged commit 7b50d4a into master Feb 6, 2018
@PabstMirror PabstMirror deleted the nvg-noise-setting branch February 6, 2018 19:38
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.2 Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants