Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Camping Light interaction #6078

Merged
merged 7 commits into from
Feb 26, 2018

Conversation

Dystopian
Copy link
Contributor

@Dystopian Dystopian commented Jan 24, 2018

When merged this pull request will:

  • add interaction to Camping Light (Turn On/Off, Drag/Carry, etc.);
  • cleanup Portable Light interaction config;
  • add icon to both lights actions.

land_camping_light_f
Camping light (lantern) is undestroyable light source which presents in some missions and sometimes it's good to turn it on/off. This object doesn't have any hitpoints and workaround should be used. Fortunately it can be handled with CollisionLightOff action.

TODO

  • drag/carry
  • cargo load
  • handle Land_Camping_Light_off_F objects - need to replace it with Land_Camping_Light_F

WIP

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Jan 24, 2018
@jonpas jonpas added this to the 3.13.0 milestone Jan 24, 2018
@Dystopian
Copy link
Contributor Author

This PR is done but cargo loading requires little cargo init rework, PR is coming.

@Dystopian
Copy link
Contributor Author

Cargo loading will work after #6085.

Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work in MP

Switching light off on non-server works for a few seconds and then switches back to on
On server, the light never turns off

switching light off on server syncs to all

@Dystopian
Copy link
Contributor Author

Yeah, I should have checked this.
One correction: not server but owner. I have checked this :)

@@ -28,6 +28,11 @@ ACE_Modifier = 0;
{_lamp setHit [_x select 0, (_x select 1) max _disabledLampDMG];nil} count _hitPointsDamage;
}] call CBA_fnc_addEventHandler;

[QGVAR(switchCollisionLight), {
params ["_target", "_player", "_state"];
_player action [["CollisionLightOff", "CollisionLightOn"] select _state, _target];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I see why I chose action instead of this command. Because of this note:

Note that the vehicle has to be local, for global variant use Arma 3 Actions "CollisionLightOn"/"CollisionLightOff"

I didn't want to use CBA events and just used these actions.
Could you remove this note from wiki please? I'll replace action with command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the note? is it invalid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, vehicle must be local for both command and action, see #6078 (review)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might only be a problem for this object simulation type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked Buoy, Road Cone, civil plane - all of them require local vehicle

@PabstMirror PabstMirror merged commit a2804f6 into acemod:master Feb 26, 2018
@Dystopian Dystopian deleted the camping_light_actions branch February 26, 2018 18:41
@Dystopian
Copy link
Contributor Author

@PabstMirror #6078 (comment)

Could you remove this note from wiki please?

@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.2 Apr 2, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Add camping light interaction

* Add dragging

* Add cargo loading

* Handle Camping_Light_off objects

* Fix work in MP

* Replace action with command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants