Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Add Smash Windshield action #6152

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

Dystopian
Copy link
Contributor

When windshield is partly damaged it becomes less clear so you may want to break it entirely.

Strings are copied from ACE2, I don't know if they are correct.

@jonpas
Copy link
Member

jonpas commented Feb 18, 2018

Do all vehicles have HitGlass1? Are none just HitGlass? What about vehicles that have multiple of them HitGlassX?

I am not sure what to do about last, I guess you could get the position from it using selectionPosition with HitPoints LOD. Then make those actions added to root model (like repair/wheel actions are). That would solve all problems.

As for hit-point names, you'd solve that by parsing them in string form, just compare HitGlass, I am pretty sure everyone uses that standard so that would be pretty safe to go with.

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Feb 18, 2018
@jonpas jonpas added this to the 3.13.0 milestone Feb 18, 2018
@PabstMirror
Copy link
Contributor

Check locality issues on setHitPointDamage

@Dystopian
Copy link
Contributor Author

Do all vehicles have HitGlass1? Are none just HitGlass? What about vehicles that have multiple of them HitGlassX?

At least vanilla, RHS, CUP. I can't check all of them, if there are issues we'll fix them. It looks like HitGlass1 is almost always driver windshield.
Moreover getHitPointDamage returns 0 if there is no such hitpoint (unlike getHit), so it's safe to check it in Quad Bike or Kart.
BTW this worked in ACE2 and I don't remember any issues with it.

I am not sure what to do about last, I guess you could get the position from it using selectionPosition with HitPoints LOD. Then make those actions added to root model (like repair/wheel actions are). That would solve all problems.

This action is SelfAction and intended to work inside only.

Check locality issues on setHitPointDamage

It's driver-only action, so vehicle is always local.

Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good for now

@PabstMirror
Copy link
Contributor

possible issue with this is a very heavily armored glass window that wouldn't be remove-able
(possibly checking armor of the hitpoint?)
but I think it's ok for now and we can tweak later if there are problems

@PabstMirror PabstMirror merged commit 601b4c1 into acemod:master Nov 2, 2018
@Dystopian Dystopian deleted the smash_windshield branch November 2, 2018 20:46
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants