Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope stats and ballistic stats improvement #6164

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Scope stats and ballistic stats improvement #6164

merged 2 commits into from
Feb 24, 2018

Conversation

alganthe
Copy link
Contributor

When merged this pull request will:

  • Hide some ballistics stats if the config entries they use aren't defined (ballistic coef / bullet mass / mag muzzle velocity) to avoid "weird" looking stats in the GL tab.
  • Add scope horizontal and vertical limits stats.

scope stats

@jonpas jonpas added this to the 3.13.0 milestone Feb 22, 2018
@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Feb 22, 2018
@ulteq
Copy link
Contributor

ulteq commented Feb 23, 2018

This is getting better and better. Nice work!

@PabstMirror PabstMirror merged commit 123c19c into acemod:master Feb 24, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.2 Apr 2, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@alganthe @PabstMirror
Scope stats and ballistic stats improvement (#6164)
90118e0 
* Hide some of the ballistic stats if config value not defined

ACE_magMuzzleVelocity
ACE_bulletMass
ACE_ballisticCoef

* Add vertical and horizontal scope limits stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.12.2
Development

Successfully merging this pull request may close these issues.
4 participants
@alganthe @ulteq @jonpas @PabstMirror