More various ace arsenal fixes #6192
Conversation
|
I don't see why this is necessary, |
|
I completely forgot it had the check ^ I don't really want compileStats being called on every page refresh when going through hundreds of items if I can avoid it. |
They aren't required anymore
|
Nearly forgot about this, since it ended up being a single line I added a bug fix with it :D |
|
|
|
new command added in dev branch: https://community.bistudio.com/wiki/findIf |
|
Is it on RC? No merge if it isn't. |
|
it was added before the RC, I didn't check if it was on RC and assumed it was, good point. |
|
Just checked, I can confirm findIf is present on the current RC build (1.82.144616) |
|
why use |
|
Because, like I said, findIf is case insensitive while in is case sensitive. |
By removing those checks the cam is allowed to clip through objects and work properly underwater, sounds like features to me :D
Switching between gunbags will keep the weapon, switching to another backpack then back to a gunbag will also keep the weapon.
|
There, included all the fixes for the issues i'm aware off. |
| private _center = EGVAR(arsenal,center); | ||
|
|
||
| if (_center call FUNC(hasGunBag)) then { | ||
| GVAR(arsenalCache) = (backpackContainer _center) getVariable [QGVAR(gunbagWeapon), []]; |
There was a problem hiding this comment.
Maybe use a more descriptive varname. As this always stores the gunbag. Why not gunbagCache?
You might want to use arsenalCache for something like an actual arsenalCache later on.
There was a problem hiding this comment.
the full var is:
ace_gunbag_arsenalCache, I don't really know if there's a more descriptive varname :/
There was a problem hiding this comment.
ooooohhhh. duh. Should've looked at what file that is. Expected it to be in arsenal
Also made the text bigger by default
* Compile stats on preInit * Remove uneeded check in add/removeStat * Remove perf profiler vars They aren't required anymore * Fix case issue in verifyLoadout, remove uneeded line * Fix ace arsenal cam not working porperly underwater By removing those checks the cam is allowed to clip through objects and work properly underwater, sounds like features to me :D * Fix gunbag behavior in ace arsenal Switching between gunbags will keep the weapon, switching to another backpack then back to a gunbag will also keep the weapon. * Fix text scaling in the searchbars and loadout name edit boxes Also made the text bigger by default
When merged this pull request will: