Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeus - Add spectator module #6202

Merged
merged 10 commits into from
May 29, 2024
Merged

Conversation

mharis001
Copy link
Member

@mharis001 mharis001 commented Mar 19, 2018

When merged this pull request will:

  • Add ACE Spectator module
    spectator_ui

It would be useful to have to the ability to make people spectators for zeus created missions, where the framework isn't necessarily integrated into the mission fully.

TODO:

  • Ability to remove players from spectating that have forced interface?

@jonpas jonpas added kind/feature Release Notes: **ADDED:** status/review-pending labels Mar 19, 2018
@jonpas jonpas added this to the 3.13.0 milestone Mar 19, 2018
@commy2
Copy link
Contributor

commy2 commented Mar 19, 2018

Translations

Unless you happen to speak any of the other languages, you don't need to add this taks to this PR :~)

Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comments, nothing to object

@mharis001 mharis001 modified the milestones: 3.13.0, 3.14.0 Dec 7, 2019
@PabstMirror PabstMirror modified the milestones: 3.15.1, Ongoing May 24, 2022
Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Not sure why we didn't think of this years ago!

Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

Ability to remove players from spectating that have forced interface?

For players that are assigned a forced interface via the module, you can "unforce" it by using the module again. I didn't test it for players that are in spectator slots, but imo that can be disregarded.

@LinkIsGrim LinkIsGrim merged commit 440b9d5 into acemod:master May 29, 2024
5 checks passed
@mharis001 mharis001 deleted the zeus-spectator branch May 29, 2024 22:08
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
Co-authored-by: Ozan Eğitmen <ozan@egitmen.net>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants