-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeus - Add spectator module #6202
Conversation
Unless you happen to speak any of the other languages, you don't need to add this taks to this PR :~) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my comments, nothing to object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Not sure why we didn't think of this years ago!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM.
Ability to remove players from spectating that have forced interface?
For players that are assigned a forced interface via the module, you can "unforce" it by using the module again. I didn't test it for players that are in spectator slots, but imo that can be disregarded.
Co-authored-by: Ozan Eğitmen <ozan@egitmen.net> Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
When merged this pull request will:
It would be useful to have to the ability to make people spectators for zeus created missions, where the framework isn't necessarily integrated into the mission fully.
TODO: