Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fastropes being blocked after rope breaking #6239

Merged
merged 5 commits into from
Apr 12, 2018
Merged

Fix fastropes being blocked after rope breaking #6239

merged 5 commits into from
Apr 12, 2018

Conversation

shukari
Copy link
Contributor

@shukari shukari commented Apr 9, 2018 •
edited
Loading

When merged this pull request will:

  • add a state to the ropes because if it breaks it currently set it as occupied and this blocks everything... you cant cut the rope and so its stuck
  • fix if FRIES ropes break the system is blocked #6209
  • tested in MP on dedi
  • if ropes break you cant fastrope but can cut them off and can redeploy them

@shukari shukari changed the title WIP: fix #6209 fix #6209 Apr 9, 2018
@shukari
Copy link
Contributor Author

shukari commented Apr 9, 2018

tested and working

@PabstMirror PabstMirror changed the title fix #6209 Fix fastropes being blocked after rope breaking Apr 9, 2018
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Apr 9, 2018
thojkooi
thojkooi reviewed Apr 11, 2018
View reviewed changes
Copy link
Contributor

@thojkooi thojkooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks about right.

@PabstMirror PabstMirror added this to the 3.12.2 milestone Apr 12, 2018
@PabstMirror PabstMirror merged commit 468da8b into acemod:master Apr 12, 2018
@shukari shukari deleted the patch-5 branch July 23, 2018 10:10
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@shukari @PabstMirror
Fix fastropes being blocked after rope breaking (#6239)
5a4bf91 
* add broken state

* add broke state

* add broken state

* add broken state

* add broken state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thojkooi thojkooi thojkooi left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.12.2
Development

Successfully merging this pull request may close these issues.

if FRIES ropes break the system is blocked
3 participants
@shukari @thojkooi @PabstMirror