Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair - Disable repair on ERA/Slat armor hitpoints #6283

Merged
merged 4 commits into from
Apr 19, 2018

Conversation

PabstMirror
Copy link
Contributor

  • Disable "miscRepair" action for all era and slat armor hitpoints.
  • Can still be repaired via "Full Repair"

ERA is consumable and it doesn't really make sense to be repairable with just a toolkit.
There are multiple hit-points and leaving them in makes interaction cluttered.

ToDo?
FullRepair has steep requirements by default (adv engineer, repair facility)
We could add a "Repair ERA" action, availiable when near a repair vehicle or facility.

Disable "miscRepair" action for all era and slat armor hitpoints.
Can still be repaired via "Full Repair"
@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** 1.82 labels Apr 18, 2018
@PabstMirror PabstMirror added this to the 3.13.0 milestone Apr 18, 2018
@PabstMirror PabstMirror changed the title Repair - Disable repair on ERA/Slat armor Repair - Disable repair on ERA/Slat armor hitpoints Apr 18, 2018
<Portuguese>Comandante Torre</Portuguese>
<Italian>Comandante Torretta</Italian>
<Hungarian>Parancsnok Lövegtorony</Hungarian>
<Russian>Командир Башню</Russian>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Башня командира

<Portuguese>Comandante Canhão</Portuguese>
<Italian>Comandante Cannone</Italian>
<Hungarian>Parancsnok Ágyú</Hungarian>
<Russian>Командир Пушку</Russian>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пушка командира

@Drofseh
Copy link
Contributor

Drofseh commented Apr 19, 2018

I might call it Replace ERA instead of Repair ERA.

I feel like ERA panels are hard to put back together after they blow up...

Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and config all looks good 👍 Can't speak for the translations

I'd do the changes to full repair/ERA repair in a separate PR

@PabstMirror PabstMirror merged commit a828ebe into master Apr 19, 2018
@PabstMirror PabstMirror deleted the repairArmorPanels branch April 19, 2018 17:31
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.3 Jul 5, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Repair - Disable repair on ERA/Slat armor

Disable "miscRepair" action for all era and slat armor hitpoints.
Can still be repaired via "Full Repair"

* Minor perf improvment

* Add hitpoint names for 1.82 comTurret/gun

* Fix russian translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants