-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair - Disable repair on ERA/Slat armor hitpoints #6283
Conversation
Disable "miscRepair" action for all era and slat armor hitpoints. Can still be repaired via "Full Repair"
addons/repair/stringtable.xml
Outdated
<Portuguese>Comandante Torre</Portuguese> | ||
<Italian>Comandante Torretta</Italian> | ||
<Hungarian>Parancsnok Lövegtorony</Hungarian> | ||
<Russian>Командир Башню</Russian> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Башня командира
addons/repair/stringtable.xml
Outdated
<Portuguese>Comandante Canhão</Portuguese> | ||
<Italian>Comandante Cannone</Italian> | ||
<Hungarian>Parancsnok Ágyú</Hungarian> | ||
<Russian>Командир Пушку</Russian> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Пушка командира
I might call it I feel like ERA panels are hard to put back together after they blow up... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and config all looks good 👍 Can't speak for the translations
I'd do the changes to full repair/ERA repair in a separate PR
* Repair - Disable repair on ERA/Slat armor Disable "miscRepair" action for all era and slat armor hitpoints. Can still be repaired via "Full Repair" * Minor perf improvment * Add hitpoint names for 1.82 comTurret/gun * Fix russian translations
ERA is consumable and it doesn't really make sense to be repairable with just a toolkit.
There are multiple hit-points and leaving them in makes interaction cluttered.
ToDo?
FullRepair has steep requirements by default (adv engineer, repair facility)
We could add a "Repair ERA" action, availiable when near a repair vehicle or facility.