Improve medical body image/interaction colouring #6288

kymckay · 2018-04-20T11:31:41Z

This makes the blood loss calculation used for the interaction menu icons match the calculation used for the body image.

Closes #4347

Edit: This has since become an implementation of the method used by ShackTac to colour the icons and body image selections. It fixes the issue and adds some granularity to the interaction icons. It does change the behaviour slightly of the body image colouring (now matches the icons from yellow through to red instead of pink through to red).

The new icons follow a "white, yellow, red" colour scale with 10 steps, Bezier interpolation and Correct lightness gradient.

Edit 2: This also now includes a tourniquet icon overlay (rather than colouring the limb blue - which is being used to now show damage again since orange is taken by blood loss).

kymckay · 2018-04-20T13:36:02Z

This is now in a state where everything is consistent and the interaction icons turn red when the body image icons start to turn to a dark red (at 0.5 blood loss). However, this may not reflect what is actually a potentially lethal blood loss - in which case we need to adjust the icon threshold and the body image calculations.

kymckay · 2018-04-21T19:48:45Z

Here's how it now looks with a tourniquet applied:

and without:

I kind of don't like the discrepancy between the icon and the body image here when a tourniquet is present, but it's how it was behaving beforehand too.

kymckay · 2018-04-22T21:30:32Z

Okay so looking further into this:

It seems that in the rewrite the body image colours were updated so that limbs went from pale to dark red based on the blood loss they had. If there was no blood loss, they then went from pale to dark orange based on the damage (previously this was done with blue - which was changed to show a limb with tourniquet applied).
The new behaviour in this PR (based on ShackTac's implementation) changes the interaction icons and limbs to step through yellow, orange, red as the blood loss increases. This definitely looks better for the icons and personally I like to have the consistency with this on the body image (it is confusing to convey the same information in two different ways based on where you're looking).
However, this now means that damage isn't displayed on the body image once blood loss is stopped (and keeping the orange would be confusing because of the blood loss changes).

So the question is, do we revert the body image colour changes (and accept inconsistency with the interaction icons)? Or, is there another colour we would want to to show damage? Another option is to adopt ShackTac's method of showing a tourniquet and apply a little overlaying icon on the limb and reverting to blue to show damage.

Drofseh · 2018-04-23T01:50:38Z

I'm more concerned with blood loss than with damage, and I think colour consistency with the interaction icons is very important.

If there is going to be an overlay icon (which I think is a good idea) I'd rather it showed damage while the limb was coloured for blood loss.

Or maybe do it like Escape from Tarkov and have coloured bars for damage.
I wouldn't use numbers like Tarkov does though.

jonpas · 2018-04-23T05:36:04Z

That makes a lot of sense, since tourniquet is on the limb image as well, comme ter with bleeding. And if damage is a bar this also directly conveys its damage.

kymckay · 2018-04-23T15:06:12Z

Currently I think I'm going to add the tourniquet image provided by ShackTac and then make it behave like the current release version where once blood loss is stopped the damage is shown in blue. That way it's consistent with older versions and there's no issue with colour overlap.

The bar is not a bad idea, I just feel that it's too accurate in comparison. Plus you don't really care about damage until the blood loss is stopped anyway, so no need to show both at once.

mharis001 · 2018-04-23T18:08:05Z

addons/medical/functions/fnc_displayPatientInformation.sqf

+                private _frBL = 0 max (_bloodLoss / BLOOD_LOSS_RED_THRESHOLD) min 1;
+                private _colorInt = ceil ((_frBL * (BLOOD_LOSS_TOTAL_COLORS - 1)));
+
+                _colorSelection = [


Should this array of colors be a macro?

I'm going to tidy a bunch of stuff up once the functionality is finalised

Drofseh · 2018-04-23T18:33:00Z

Yah, I don't really care about seeing damage at all tbh, well, unless treatment for damage is significantly different in the rewrite.

Right now in 3.12.2 you either require a PAK or you have to have bandages heal damage turned on right?
Is that changed in the rewrite?

kymckay · 2018-04-23T20:01:03Z

The final result:

As you can see one leg is damaged but not bleeding, while the other was bleeding. Both have a tourniquet applied to show how the colour looks.

TheMagnetar · 2018-04-24T11:20:32Z

addons/medical_menu/CfgVehicles.hpp

@@ -48,7 +48,7 @@ class CfgVehicles {
                displayName = ECSTRING(medical,Actions_Medical);
                runOnHover = 1;
                exceptions[] = {"isNotInside", "isNotSitting"};
-                statement = QUOTE([ARR_3(_target,1,0)] call EFUNC(medical,displayPatientInformation));
+                statement = QUOTE([ARR_3(_target,1,0)] call EFUNC(medical_ui,displayPatientInformation));
                condition = "true";
                icon = QPATHTOEF(medical,UI\icons\medical_cross.paa);


This binary file (medical_cross.paa) is removed in this PR but the code still references it

Well spotted, thanks 👍

kymckay · 2018-04-24T17:33:54Z

If #6290 gets merged in future we can just use a single basic cross icon and update the colour of it. Then we only need multiple of the tourniquet icons since they retain the white outer ring.

kymckay · 2018-04-24T17:50:09Z

One thing I'm not totally sure about is at what level of a damage a selection should reach the bluest blue. Currently it's set to 0.8 (here), but that's just because I mistakenly thought damage was in the range [0,1] when actually it seems to just keep going up (a single pistol shot seems to instantly make a limb the highest level of blue).

The issue is actually the other way round, the factor of 20 would instantly make bodyparts red on taking a wound.

This replaces the old method of colouring the interaction menu icons and body image selections with a new method that has 10 distinct color steps (matching across the icons and the body image).

This re-adds visualisation for colouring based on damage. The case where a limb has a tourniquet will hopefully be handled by an overlayed icon.

mharis001 · 2019-03-24T22:26:29Z

Included in #6831 .

kymckay added the kind/bug-fix Release Notes: **FIXED:** label Apr 20, 2018

kymckay added this to the Medical Rewrite milestone Apr 20, 2018

This comment has been minimized.

Sign in to view

kymckay added the status/WIP label Apr 20, 2018

This comment has been minimized.

Sign in to view

kymckay removed the status/WIP label Apr 21, 2018

kymckay changed the title ~~Fix medical interaction menu bleeding colours~~ Improve medical body image/interaction colouring Apr 22, 2018

kymckay added the kind/enhancement Release Notes: **IMPROVED:** label Apr 23, 2018

mharis001 reviewed Apr 23, 2018

View reviewed changes

TheMagnetar reviewed Apr 24, 2018

View reviewed changes

kymckay added 7 commits July 18, 2018 20:12

Add a macro for the bloodloss scaling factor

42ce917

Adjust bloodloss threshold for red icon

f75c389

Remove bloodloss color scaling factor

dd874c8

The issue is actually the other way round, the factor of 20 would instantly make bodyparts red on taking a wound.

Implemet 10 color steps provided by ShackTac

43c066e

This replaces the old method of colouring the interaction menu icons and body image selections with a new method that has 10 distinct color steps (matching across the icons and the body image).

Use macros for constants

7300afb

Implement blue damage colouring

947ae3e

This re-adds visualisation for colouring based on damage. The case where a limb has a tourniquet will hopefully be handled by an overlayed icon.

Tidy up file structure

015b734

kymckay added 6 commits July 18, 2018 20:32

Move patient information display to medical_ui

f16ec8b

Make common colour conversion code into functions

37632db

Add tourniquet icon overlay to body image

2b0ef1e

Fix mispelling I forgot to commit

7763583

Update icon paths to new white cross icon

2f1f1af

Clean mess after rebase

8f80eac

kymckay force-pushed the medical-rw-icon-color branch from 5eb6a38 to 8f80eac Compare July 18, 2018 19:52

kymckay requested a review from thojkooi August 4, 2018 09:15

Merge branch 'medical-rewrite' into medical-rw-icon-color

9aec56c

mharis001 mentioned this pull request Feb 22, 2019

Rewrite Medical GUI #6831

Merged

7 tasks

mharis001 closed this Mar 24, 2019

mharis001 deleted the medical-rw-icon-color branch March 24, 2019 23:32

PabstMirror modified the milestones: Medical Rewrite, 3.13.0, 3.13.0-temp3 Dec 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve medical body image/interaction colouring #6288

Improve medical body image/interaction colouring #6288

kymckay commented Apr 20, 2018 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kymckay commented Apr 20, 2018

kymckay commented Apr 21, 2018 •

edited

Loading

kymckay commented Apr 22, 2018

Drofseh commented Apr 23, 2018

jonpas commented Apr 23, 2018

kymckay commented Apr 23, 2018 •

edited

Loading

mharis001 Apr 23, 2018

kymckay Apr 23, 2018

Drofseh commented Apr 23, 2018

kymckay commented Apr 23, 2018

TheMagnetar Apr 24, 2018 •

edited

Loading

kymckay Apr 24, 2018

kymckay commented Apr 24, 2018

kymckay commented Apr 24, 2018

mharis001 commented Mar 24, 2019

Improve medical body image/interaction colouring #6288

Improve medical body image/interaction colouring #6288

Conversation

kymckay commented Apr 20, 2018 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kymckay commented Apr 20, 2018

kymckay commented Apr 21, 2018 • edited Loading

kymckay commented Apr 22, 2018

Drofseh commented Apr 23, 2018

jonpas commented Apr 23, 2018

kymckay commented Apr 23, 2018 • edited Loading

mharis001 Apr 23, 2018

Choose a reason for hiding this comment

kymckay Apr 23, 2018

Choose a reason for hiding this comment

Drofseh commented Apr 23, 2018

kymckay commented Apr 23, 2018

TheMagnetar Apr 24, 2018 • edited Loading

Choose a reason for hiding this comment

kymckay Apr 24, 2018

Choose a reason for hiding this comment

kymckay commented Apr 24, 2018

kymckay commented Apr 24, 2018

mharis001 commented Mar 24, 2019

kymckay commented Apr 20, 2018 •

edited

Loading

kymckay commented Apr 21, 2018 •

edited

Loading

kymckay commented Apr 23, 2018 •

edited

Loading

TheMagnetar Apr 24, 2018 •

edited

Loading