Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map - Fix ambient light effect flicking #6313

Merged
merged 3 commits into from
Apr 28, 2018
Merged

Conversation

PabstMirror
Copy link
Contributor

Fix #6298

Old and new both look the same to me, but old has terrible flicking.
The change in numbers over time is incredible small (like 0.0002 change every 0.1 seconds).
It almost seems each time you reference a new procedural texture (like #(rgb,8,8,3)color(0.95846,0.001,0.0056,1)) it isn't available that frame, so you get a frame with no texture (the flicker); but that's a pretty rough theory.
I believe this may have broken in 1.82.

Feel free to test effects with

if ((diag_tickTime % 4) < 2) then {
    systemChat "old";
    _mapCtrl drawIcon [format["#(rgb,8,8,3)color(%1,%2,%3,1)", _r / _maxColour, _g / _maxColour, _b / _maxColour], [1,1,1,_colourAlpha], _mapCentre, _screenSize, _screenSize, 0, "", 0];
} else {
    systemChat "new";
    _mapCtrl drawIcon [format["#(rgb,8,8,3)color(1,1,1,1)"], [_r / _maxColour, _g / _maxColour, _b / _maxColour,_colourAlpha], _mapCentre, _screenSize, _screenSize, 0, "", 0];
};

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Apr 28, 2018
@PabstMirror PabstMirror added this to the 3.13.0 milestone Apr 28, 2018
@PabstMirror PabstMirror merged commit ab23f4e into master Apr 28, 2018
@PabstMirror PabstMirror deleted the fixMapLightingFlicker branch April 28, 2018 22:24
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.3 Jul 5, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Map - Fix ambient light effect flicking

* Remove format

* formating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants