Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Translation Tweak #6375

Merged
merged 2 commits into from May 31, 2018
Merged

Japanese Translation Tweak #6375

merged 2 commits into from May 31, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2018

  • fixed typo
  • improved readability
  • standardized expression

- fixed typo
- improved readability
- standardized expression
@PabstMirror PabstMirror added the kind/translation Release Notes: **TRANSLATIONS:** label May 30, 2018
@PabstMirror PabstMirror added this to the 3.13.0 milestone May 30, 2018
@PabstMirror
Copy link
Contributor

@classicarma - Do these changes look ok?

@classicarma
Copy link
Contributor

@PabstMirror Almost perfect but I have added a comment to the translations.

@@ -160,7 +160,7 @@
<Key ID="STR_ACE_Advanced_Throwing_dropModeHold">
<English>Throwable Drop Mode (Hold)</English>
<Russian>Режим броска гранаты (удерживать)</Russian>
<Japanese>投てきモード (押しっぱ)</Japanese>
<Japanese>投てきモード (押している間)</Japanese>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "長押し" are best.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this and it's okay. please approve this pull-request

@PabstMirror PabstMirror merged commit a5a8c68 into acemod:master May 31, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.3 Jul 5, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
- fixed typo
- improved readability
- standardized expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants