Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo load ignore interaction distance parameter #6395

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Cargo load ignore interaction distance parameter #6395

merged 4 commits into from
Jun 18, 2018

Conversation

tbeswick96
Copy link
Contributor

When merged this pull request will:

  • Add an optional parameter to ace_cargo_loadItem & ace_cargo_canLoadItemIn
  • Parameter allows interaction distance check in ace_cargo_canLoadItemIn to be ignored
  • I needed this for a persistence implementation where supply boxes with inventories as ace cargo are made persistent, and couldn't previously be loaded in due to distance
  • Maybe someone else will find this useful

@jonpas
Copy link
Member

jonpas commented Jun 17, 2018

Nice! I wanted this. :D

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jun 17, 2018
@PabstMirror PabstMirror added this to the 3.13.0 milestone Jun 17, 2018
dedmen
dedmen approved these changes Jun 17, 2018
View reviewed changes
Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o7

@PabstMirror
Copy link
Contributor

Would we want to use this to remove distance check on zeus cargo loading?

@PabstMirror PabstMirror merged commit c0b9a31 into acemod:master Jun 18, 2018
@tbeswick96 tbeswick96 deleted the cargo-load-force branch June 18, 2018 20:03
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.3 Jul 5, 2018
@PabstMirror PabstMirror mentioned this pull request Jul 21, 2018
Merged
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@tbeswick96 @PabstMirror
Cargo load ignore interaction distance parameter (#6395)
cacd947 
* Added force parameter to cargo load

* Specifically ignore interaction distance

* Fixed old brackets

* Removed old trace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@dedmen dedmen dedmen approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.12.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tbeswick96 @jonpas @PabstMirror @dedmen