don't make Explosives close one display at death #6405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
approved these changes
Jun 24, 2018
|
caused by 54320eb |
|
I shouldn't have doubted CorruptedHeart for a second. |
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
don't make Explosives close one display at death
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explosives closes one display at killed.
This breaks e.g. the Life Respawn menu.
This PR makes the component no longer kill a display indiscriminately, but only the Cellphone one.
Debug script:
Before this PR: no display created, after this PR: display created successfully.
Note: don't run the code twice. Only one display is closed, so executing it twice seemingly fixes the issue, but doesn't really.