Explosives - Optimize interactEH function #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharis001
changed the title
dedmen
approved these changes
Jun 25, 2018
| } else { | ||
| // Prevent Rare Error when ending mission with interact key down: | ||
| if (isNull ace_player) exitWith {}; | ||
| if (isNull ACE_player) exitWith {}; | ||
| private _player = ACE_player; |
There was a problem hiding this comment.
Accessing global variable is slower than local. So swap the order of the isNull and _player and reuse _player maybe.
| //If player moved >5 meters from last pos, then rescan | ||
| if (((getPosASL ace_player) distance _setPosition) > 5) then { | ||
| // Rescan if player has moved more than 5 meters from last position | ||
| if (_playerPos distance _setPosition > 5) then { |
There was a problem hiding this comment.
distanceSqr? But I don't think that makes enough difference
|
I changed it from public Yes to No, because I don't see any reason why this function would be a public function. |
PabstMirror
approved these changes
Jul 13, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Optimize explosives interactEH * Use local player variable and distanceSqr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
interactEHfunction (various minor improvements but mainlycreateVehicleLocal [0, 0, 0])Performance results for
ace_explosives_interactEH_counter: