Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ace_infoDisplayChanged will now trigger also for mods #6422

Merged
merged 2 commits into from
Jul 13, 2018
Merged

ace_infoDisplayChanged will now trigger also for mods #6422

merged 2 commits into from
Jul 13, 2018

Conversation

shukari
Copy link
Contributor

@shukari shukari commented Jul 9, 2018

When merged this pull request will:

  • add 'RscUnitInfo' to Extended_DisplayLoad_EventHandlers
  • because 90% of the RscInGameUIs are use BIS_fnc_initDisplay with RscUnitInfo
  • instead of adding onLoad to all mod RscInGameUIs (example: RHS) it will go over the cba xeh

This works now perfect for my desire, the rhs jets now also get a limited UI by the Ace_UI addon. But i dont know what side effects this triggers.

@jonpas
Copy link
Member

jonpas commented Jul 9, 2018

There shouldn't be any side effects from ACE UI itself, only added support (which is great!), I am not sure about other things though, @commy2 ?

@jonpas jonpas added this to the 3.12.3 milestone Jul 9, 2018
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one way to find out. :)

@PabstMirror
Copy link
Contributor

uiNamespace setVariable [ARR_2('ACE_dlgSoldier', _this select 0)];
I can't find any use of the ACE_dlg* variables in our code, anyone know what they were for?

@jonpas
Copy link
Member

jonpas commented Jul 13, 2018

Reads like "dialog" to me.

@PabstMirror
Copy link
Contributor

If it's just a old thing from AGM we might be able to drop the entire line, but it doesn't really hurt.

@PabstMirror PabstMirror merged commit 5fe8266 into acemod:master Jul 13, 2018
@shukari shukari deleted the patch-7 branch July 23, 2018 10:06
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* add RscUnitInfo to DisplayLoad eh

* delete all ace_infoDisplayChanged that also have initDisplay with RscUnitInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants