Improvements to vitals and display #6444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thojkooi
requested changes
Jul 18, 2018
| _genericMessages pushBack [localize ELSTRING(medical,Status_Lost_Blood), [1, 0.1, 0.1, 1]]; | ||
| // Show more information if advancedDiagnose is enabled | ||
| if (EGVAR(medical,advancedDiagnose)) then { | ||
| if (GET_HEMORRHAGE(_target) == 1) then { |
There was a problem hiding this comment.
This should probably be a switch statement.
kymckay
reviewed
Jul 18, 2018
addons/medical/stringtable.xml
Outdated
| @@ -1031,6 +1031,15 @@ | |||
| <Chinesesimp>大量失血中</Chinesesimp> | |||
| <Chinese>大量失血中</Chinese> | |||
| </Key> | |||
| <Key ID="STR_ACE_Medical_Status_Lost_Blood2"> | |||
| <English>Lost some blood Class II Hemorrhage</English> | |||
There was a problem hiding this comment.
Haven't seen how it looks in game, but it seems odd to me that the class directly runs on from the description in these strings
There was a problem hiding this comment.
I think the messages will be fine if we remove the class bit.
thojkooi
changed the base branch from
medical-rewrite-restructure
to
medical-rewrite
thojkooi
approved these changes
Jul 18, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
- Improvements to vitals and display - Fixes some undeclared variables - Adds advanced diagnose: hemorrhage classes. - Original idea for displaying hemorrhage classes belongs to @Arcanum417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: