Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes unit vitals rw #6449

Merged
merged 5 commits into from
Jul 20, 2018
Merged

Changes unit vitals rw #6449

merged 5 commits into from
Jul 20, 2018

Conversation

TheMagnetar
Copy link
Member

@TheMagnetar TheMagnetar commented Jul 18, 2018 •
edited
Loading

When merged this pull request will:

  • Enter in cardiac arrest state if 50/40 blood pressure and heart rate is below 40.
  • Chance to enter cardiac arrest if heart rate is below 30 but higher than 20.
  • Enter cardiac arrest if Blood pressure L is above 190.

@TheMagnetar TheMagnetar added this to the Medical Rewrite milestone Jul 18, 2018
@TheMagnetar TheMagnetar requested review from thojkooi and kymckay July 18, 2018 20:27
kymckay
kymckay reviewed Jul 19, 2018
View reviewed changes
Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks good! 👍

I can't personally speak as to whether these conditions make sense medically though

addons/medical_vitals/functions/fnc_handleUnitVitals.sqf Outdated
case (_heartRate < 30): { // With a heart rate below 30 but bigger than 20 there is a chance to enter the cardiac arrest state
private _lastCheck = _unit getVariable [QGVAR(lastCheckCriticalHeartRate), CBA_missionTime];
private _enterCardiacArrest = false;
if (_lastCheck <= CBA_missionTime) then {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor readability thing, but I'd probably change this to _nextCheck and swap the inequality comparison around to CBA_missionTime > _nextCheck. Just makes the intention of the code more clear (to me at least).

@thojkooi thojkooi added kind/enhancement Release Notes: **IMPROVED:** area/focus-feature labels Jul 20, 2018
@thojkooi thojkooi merged commit b8cd851 into medical-rewrite Jul 20, 2018
@thojkooi thojkooi deleted the ChangesUnitVitals-rw branch July 20, 2018 20:49
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@TheMagnetar @thojkooi
Changes unit vitals rw (#6449)
95c871e 
* Some changes to UnitVitals

* increase to 40% chance

* Added bloodpressure L above limits cardiac arrest
@PabstMirror PabstMirror modified the milestones: Medical Rewrite, 3.13.0 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kymckay kymckay kymckay left review comments

@thojkooi thojkooi thojkooi approved these changes

Assignees
No one assigned
Labels
area/focus-feature kind/enhancement Release Notes: **IMPROVED:**
Projects
ACE3 Medical Focus Feature
Status: Completed
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TheMagnetar @thojkooi @kymckay @PabstMirror