Wire cutter - Allow use when unit has RHS Engineer UMBTS backpack #6462
Conversation
|
Gives it a 5 mass capacity advantage over standardised Assault Packs. Considering most of that is carried on the outside, I'd be ok with that. Not sure what to think about the precedent of adding functionality to other mods simply based on cosmetic aspects of their models though. And how well does that code work when you don't have RHS loaded? Does it still work if it is replaced with some kind of macro in case other examples crop up? |
|
|
||
| #define HAS_WIRECUTTER(unit) (\ | ||
| "ACE_wirecutter" in ([ARR_6(unit, false, true, true, true, false)] call CBA_fnc_uniqueUnitItems) \ | ||
| || {backpack unit isKindOf "rhs_assault_umbts_engineer"} \ |
There was a problem hiding this comment.
Backpacks that inherit from this are not guaranteed to have a model with a wirecutter on it.
There was a problem hiding this comment.
I would rather see something config based like
1 == getNumber (configFile >> "CfgVehicles" >> (backpack unit) >> QGVAR(hasWirecutter))
instead of hard coded classes
There was a problem hiding this comment.
@dedmen Yes. Right now there are 3 backpacks with this model. I decided not to check model in backpack config (which can also be changed in any RHS update) but just check inheritance. I think it is enough for now. If you insist I'll change the check.
There was a problem hiding this comment.
@PabstMirror I would implement it if there was at least very small probability for other such backpacks.
It works OK. I thought about init checking if RHS is loaded and then replacing code with just
If there are more examples it would be very easy to add their support. Until then there is no sense to do it. |
@jokoho48 mentioned VSM and another mod that even had them on vests. Haven't touched either in ages, but even if there isn't anything in those - I'd still try and keep this future proof. |
| @@ -59,5 +59,6 @@ | |||
|
|
|||
| #define HAS_WIRECUTTER(unit) (\ | |||
| "ACE_wirecutter" in ([ARR_6(unit, false, true, true, true, false)] call CBA_fnc_uniqueUnitItems) \ | |||
| || {backpack unit isKindOf "rhs_assault_umbts_engineer"} \ | |||
| || {1 == getNumber (configFile >> "CfgVehicles" >> (backpack unit) >> QGVAR(hasWirecutter))} \ | |||
| || {1 == getNumber (configFile >> "CfgWeapons" >> (vest unit) >> QGVAR(hasWirecutter))} \ | |||
There was a problem hiding this comment.
They are Items/CfgWeapons.
There is a vestContainer command, that returns the vest "object"
but typeOf vestContainer player = "Supply140"
There was a problem hiding this comment.
PabstMirror
changed the title
When merged this pull request will:
Class namerhs_assault_umbts_engineeris hard-coded on purpose because I didn't find any analogues in vanilla, RHS and CUP gear.