Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce bleedout condition and fix IV hemorrhage #6470

Merged
merged 6 commits into from
Jul 25, 2018

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented Jul 24, 2018

When merged this pull request will:

  • Add a death condition for units who've lost more than 50% of their original blood volume
  • Change the blood volume cardiac arrest condition to occur after 40% is lost (class IV hemorrhage) to emulate hypovolemic shock

Source on those values:
https://www.medicaldaily.com/breaking-point-how-much-blood-can-human-body-lose-350792

This PR relates to #6277 in that the fatal injury system really is designed to emulate damage to vital organs and so allowing it to occur on any bodypart isn't using it as intended. Instead, if we introduce a bleedout death condition we fix #5510 via another means which makes more sense. #6277 can then be re-purposed to allow fatal injury on the torso to emulate damage to organs located there.

We probably need to investigate the current bleed rates in the rewrite and tweak the factors on those to be balanced to these realistic limits on blood volume.

A class IV hemorrhage will induce hypovolemic shock (essentially a state
preceding death, but we're a bit more forgiving).
@kymckay kymckay added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Jul 24, 2018
@kymckay kymckay added this to the Medical Rewrite milestone Jul 24, 2018
@@ -105,6 +105,10 @@ class ACE_Medical_StateMachine {
condition = QFUNC(conditionExecutionDeath);
events[] = {QEGVAR(medical,FatalInjury)};
};
class Bleedout {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This transition needs to be added to the other states as well. Otherwise if blood volume drops significantly you could potentially by pass the cardiac arrest state and end up with bleedout events without transitioning into a different state.

Copy link
Member

@TheMagnetar TheMagnetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kymckay
Copy link
Member Author

kymckay commented Jul 25, 2018

Good catch, I've now updated both places where hemorrhage value is used in the UI (moved the strings associated over while I was at it). 👍

I'll probably change the way those are done in another PR as currently it seems a little off.

<!--
Strings above and below this seem to differ in some languages, determine which is best to use
-->
<Key ID="STR_ACE_Medical_GUI_Lost_Blood1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After seeing the text strings, I would rename this one as "GUI_Lost_BloodGeneric" to avoid confusion with Blood2 message. Blood1 is "Lost a lot of blood", Blood2 is "Lost some blood".

This is a minor wish. so PR approved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is what I meant about them being off, I'll make a separate PR to fix these

@kymckay kymckay merged commit 873ed90 into medical-rewrite Jul 25, 2018
@kymckay kymckay deleted the rw-bleedout branch July 25, 2018 10:40
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Introduce bleedout condition and fix IV hemorrhage
* Update patient info display hemorrhage values
* Update UI info hemorrhage values
@PabstMirror PabstMirror modified the milestones: Medical Rewrite, 3.13.0 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
Development

Successfully merging this pull request may close these issues.

4 participants