-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce bleedout condition and fix IV hemorrhage #6470
Conversation
A class IV hemorrhage will induce hypovolemic shock (essentially a state preceding death, but we're a bit more forgiving).
@@ -105,6 +105,10 @@ class ACE_Medical_StateMachine { | |||
condition = QFUNC(conditionExecutionDeath); | |||
events[] = {QEGVAR(medical,FatalInjury)}; | |||
}; | |||
class Bleedout { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This transition needs to be added to the other states as well. Otherwise if blood volume drops significantly you could potentially by pass the cardiac arrest state and end up with bleedout events without transitioning into a different state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do so, it is also necessary to update fnc_displayPatientInformation:
Good catch, I've now updated both places where hemorrhage value is used in the UI (moved the strings associated over while I was at it). 👍 I'll probably change the way those are done in another PR as currently it seems a little off. |
<!-- | ||
Strings above and below this seem to differ in some languages, determine which is best to use | ||
--> | ||
<Key ID="STR_ACE_Medical_GUI_Lost_Blood1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After seeing the text strings, I would rename this one as "GUI_Lost_BloodGeneric" to avoid confusion with Blood2 message. Blood1 is "Lost a lot of blood", Blood2 is "Lost some blood".
This is a minor wish. so PR approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is what I meant about them being off, I'll make a separate PR to fix these
* Introduce bleedout condition and fix IV hemorrhage * Update patient info display hemorrhage values * Update UI info hemorrhage values
When merged this pull request will:
Source on those values:
https://www.medicaldaily.com/breaking-point-how-much-blood-can-human-body-lose-350792
This PR relates to #6277 in that the fatal injury system really is designed to emulate damage to vital organs and so allowing it to occur on any bodypart isn't using it as intended. Instead, if we introduce a bleedout death condition we fix #5510 via another means which makes more sense. #6277 can then be re-purposed to allow fatal injury on the torso to emulate damage to organs located there.
We probably need to investigate the current bleed rates in the rewrite and tweak the factors on those to be balanced to these realistic limits on blood volume.