Repair - Fix facility is like vehicle

[Dystopian]

When merged this pull request will:

• (1) fix config-based facility acts as repair vehicles;
• fix repair at dead facility (if it's possible);
• optimize fnc_isInRepairFacility a little.

(1) Config-based facilities have the same config value name as repair vehicles (GVAR(canRepair)). When there is a dead config-based repair vehicle near it becomes repair facility and can affect repair routines. This PR excludes AllVehicles child classes from facilities. Maybe simulation check would be more efficient but I think it's OK.

[PabstMirror]

good catch

[PabstMirror]

I'm not sure, but should we also change the default setting to vehicleAndFacility?
This would ensure consistent behaviour with previous versions

https://github.com/acemod/ACE3/blob/master/addons/repair/initSettings.sqf#L61
2->3

[Dystopian]

Looks like it was always default repairVehicleOnlyrepairFacilityOnly and now it's the same. It was added by @thojkooi in #186:

ACE3/addons/repair/ACE_Settings.hpp

Lines 47 to 48 in 83f46be

	value = 2;
	values[] = {CSTRING(useAnywhere), CSTRING(repairVehicleOnly), CSTRING(repairFacilityOnly), CSTRING(vehicleAndFacility), ECSTRING(common,Disabled)};

and at the same time module had repairFacilityOnly as default:

ACE3/addons/repair/CfgVehicles.hpp

Line 80 in 83f46be

class facility { name = CSTRING(repairFacilityOnly); value = 2; default = 1; };

So I think at least his opinion is important.

[kymckay]

@Dystopian You mean repairFacilityOnly in the first sentence, right?

[Dystopian]

@SilentSpike No, I meant exactly repairVehicleOnly. I decided value is counted from 1 because near

ACE3/addons/repair/ACE_Settings.hpp

Lines 54 to 55 in 83f46be

	value = 3;
	values[] = {CSTRING(engineerSetting_anyone), CSTRING(engineerSetting_EngineerOnly), CSTRING(engineerSetting_RepairSpecialistOnly)};

[Dystopian]

And it was fixed in #2364 😆 Then repairFacilityOnly was default.