Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair - Make eden attributes use config values as default #6480

Merged
merged 2 commits into from
Oct 21, 2018

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • make ace_isEngineer attribute use vanilla engineer value as default;
  • make ace_isRepairVehicle and ace_isRepairFacility attributes use config values as default;
  • make these attributes init code assign variables only if they differ from default values;
  • simplify config with inheritance.

ace_isEngineer attribute init code is more complicated a little because it considers Default attribute value.

@PabstMirror PabstMirror added this to the 3.13.0 milestone Oct 21, 2018
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Oct 21, 2018
@PabstMirror PabstMirror merged commit fefba89 into acemod:master Oct 21, 2018
@Dystopian Dystopian deleted the fix_repair_eden_attributes branch October 22, 2018 21:59
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Make eden attributes use config values as default

* Simplify config with inheritance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants